Re: [Mesa-dev] [PATCH 01/17] r200: Remove dead rop table

[Ian Romanick]

I thought I removed that... thanks for taking care of this.

Reviewed-by: Ian Romanick 

On 02/10/2018 08:32 AM, Eric Anholt wrote:
> Fixes: 0aaa27f29187 ("mesa: Pass the translated color logic op 
> dd_function_table::LogicOpcode")
> Cc: Ian Romanick 
> ---
>  src/mesa/drivers/dri/r200/r200_state.c | 20 
>  1 file changed, 20 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/r200/r200_state.c 
> b/src/mesa/drivers/dri/r200/r200_state.c
> index 33b696347a3d..d53225d63abe 100644
> --- a/src/mesa/drivers/dri/r200/r200_state.c
> +++ b/src/mesa/drivers/dri/r200/r200_state.c
> @@ -1626,26 +1626,6 @@ static void r200RenderMode( struct gl_context *ctx, 
> GLenum mode )
> FALLBACK( rmesa, R200_FALLBACK_RENDER_MODE, (mode != GL_RENDER) );
>  }
>  
> -
> -static GLuint r200_rop_tab[] = {
> -   R200_ROP_CLEAR,
> -   R200_ROP_AND,
> -   R200_ROP_AND_REVERSE,
> -   R200_ROP_COPY,
> -   R200_ROP_AND_INVERTED,
> -   R200_ROP_NOOP,
> -   R200_ROP_XOR,
> -   R200_ROP_OR,
> -   R200_ROP_NOR,
> -   R200_ROP_EQUIV,
> -   R200_ROP_INVERT,
> -   R200_ROP_OR_REVERSE,
> -   R200_ROP_COPY_INVERTED,
> -   R200_ROP_OR_INVERTED,
> -   R200_ROP_NAND,
> -   R200_ROP_SET,
> -};
> -
>  static void r200LogicOpCode(struct gl_context *ctx, enum gl_logicop_mode 
> opcode)
>  {
> r200ContextPtr rmesa = R200_CONTEXT(ctx);
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 01/17] r200: Remove dead rop table

[Elie Tournier]

Eric Engestrom was faster. ;)
https://patchwork.freedesktop.org/patch/203691/

On 10 February 2018 at 16:32, Eric Anholt  wrote:
> Fixes: 0aaa27f29187 ("mesa: Pass the translated color logic op 
> dd_function_table::LogicOpcode")
> Cc: Ian Romanick 
> ---
>  src/mesa/drivers/dri/r200/r200_state.c | 20 
>  1 file changed, 20 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/r200/r200_state.c 
> b/src/mesa/drivers/dri/r200/r200_state.c
> index 33b696347a3d..d53225d63abe 100644
> --- a/src/mesa/drivers/dri/r200/r200_state.c
> +++ b/src/mesa/drivers/dri/r200/r200_state.c
> @@ -1626,26 +1626,6 @@ static void r200RenderMode( struct gl_context *ctx, 
> GLenum mode )
> FALLBACK( rmesa, R200_FALLBACK_RENDER_MODE, (mode != GL_RENDER) );
>  }
>
> -
> -static GLuint r200_rop_tab[] = {
> -   R200_ROP_CLEAR,
> -   R200_ROP_AND,
> -   R200_ROP_AND_REVERSE,
> -   R200_ROP_COPY,
> -   R200_ROP_AND_INVERTED,
> -   R200_ROP_NOOP,
> -   R200_ROP_XOR,
> -   R200_ROP_OR,
> -   R200_ROP_NOR,
> -   R200_ROP_EQUIV,
> -   R200_ROP_INVERT,
> -   R200_ROP_OR_REVERSE,
> -   R200_ROP_COPY_INVERTED,
> -   R200_ROP_OR_INVERTED,
> -   R200_ROP_NAND,
> -   R200_ROP_SET,
> -};
> -
>  static void r200LogicOpCode(struct gl_context *ctx, enum gl_logicop_mode 
> opcode)
>  {
> r200ContextPtr rmesa = R200_CONTEXT(ctx);
> --
> 2.15.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev