Re: [Mesa-dev] [PATCH 1/2] clover: Allow overriding platform/device version numbers

2018-03-02 Thread Francisco Jerez
Emil Velikov writes: > Hi Aaron, > > On 1 March 2018 at 19:44, Aaron Watry wrote: >> Useful for testing API, builtin library, and device completeness of >> not-yet-supported versions. >> > Small fly-by comment: > > As-is it seems like getenv(foo) will

Re: [Mesa-dev] [PATCH 1/2] clover: Allow overriding platform/device version numbers

2018-03-02 Thread Emil Velikov
Hi Aaron, On 1 March 2018 at 19:44, Aaron Watry wrote: > Useful for testing API, builtin library, and device completeness of > not-yet-supported versions. > Small fly-by comment: As-is it seems like getenv(foo) will be called multiple times. Perhaps it isn't that 'slow' since

Re: [Mesa-dev] [PATCH 1/2] clover: Allow overriding platform/device version numbers

2018-03-01 Thread Francisco Jerez
Aaron Watry writes: > Useful for testing API, builtin library, and device completeness of > not-yet-supported versions. > > Signed-off-by: Aaron Watry > Cc: Pierre Moreau > Cc: Jan Vesely > Cc: Francisco Jerez

Re: [Mesa-dev] [PATCH 1/2] clover: Allow overriding platform/device version numbers

2018-03-01 Thread Pierre Moreau
Reviewed-by: Pierre Moreau On 2018-03-01 — 13:44, Aaron Watry wrote: > Useful for testing API, builtin library, and device completeness of > not-yet-supported versions. > > Signed-off-by: Aaron Watry > Cc: Pierre Moreau > Cc: Jan