Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix buffer overruns in MSAA MCS buffer clearing.

2014-04-15 Thread Courtney Goeltzenleuchter
What timing, we were just looking at this exact issue - intermittent glxgears rendering issues when using multisample buffers. What's the plan for DRM? Seems like it's broken if writing to the buffer size indicated (bo-size) causes us to clobber other BOs. Courtney On Mon, Apr 14, 2014 at 8:54

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix buffer overruns in MSAA MCS buffer clearing.

2014-04-15 Thread Mike Stroyan
I would go farther than requiring the returned bo-size to be covered by backing pages. There really should be backing pages for every page mapped by drm_intel_gem_bo_map. No mapped addresses should be affecting memory outside of an object's backing pages. If tiling can result in access to

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix buffer overruns in MSAA MCS buffer clearing.

2014-04-15 Thread Courtney Goeltzenleuchter
On Tue, Apr 15, 2014 at 1:18 PM, Eric Anholt e...@anholt.net wrote: Kenneth Graunke kenn...@whitecape.org writes: On 04/14/2014 05:33 PM, Eric Anholt wrote: This manifested as rendering failures or sometimes GPU hangs in compositors when they accidentally got MSAA visuals due to a bug in

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix buffer overruns in MSAA MCS buffer clearing.

2014-04-15 Thread Eric Anholt
Courtney Goeltzenleuchter court...@lunarg.com writes: On Tue, Apr 15, 2014 at 1:18 PM, Eric Anholt e...@anholt.net wrote: Kenneth Graunke kenn...@whitecape.org writes: On 04/14/2014 05:33 PM, Eric Anholt wrote: This manifested as rendering failures or sometimes GPU hangs in compositors

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix buffer overruns in MSAA MCS buffer clearing.

2014-04-15 Thread Courtney Goeltzenleuchter
On Tue, Apr 15, 2014 at 2:16 PM, Eric Anholt e...@anholt.net wrote: Courtney Goeltzenleuchter court...@lunarg.com writes: On Tue, Apr 15, 2014 at 1:18 PM, Eric Anholt e...@anholt.net wrote: Kenneth Graunke kenn...@whitecape.org writes: On 04/14/2014 05:33 PM, Eric Anholt wrote:

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix buffer overruns in MSAA MCS buffer clearing.

2014-04-15 Thread Kenneth Graunke
On 04/15/2014 10:08 AM, Mike Stroyan wrote: I would go farther than requiring the returned bo-size to be covered by backing pages. There really should be backing pages for every page mapped by drm_intel_gem_bo_map. No mapped addresses should be affecting memory outside of an object's backing

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix buffer overruns in MSAA MCS buffer clearing.

2014-04-15 Thread Ian Romanick
On 04/15/2014 03:50 PM, Kenneth Graunke wrote: On 04/15/2014 10:08 AM, Mike Stroyan wrote: I would go farther than requiring the returned bo-size to be covered by backing pages. There really should be backing pages for every page mapped by drm_intel_gem_bo_map. No mapped addresses should be

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix buffer overruns in MSAA MCS buffer clearing.

2014-04-15 Thread Chia-I Wu
On Wed, Apr 16, 2014 at 3:18 AM, Eric Anholt e...@anholt.net wrote: Kenneth Graunke kenn...@whitecape.org writes: On 04/14/2014 05:33 PM, Eric Anholt wrote: This manifested as rendering failures or sometimes GPU hangs in compositors when they accidentally got MSAA visuals due to a bug in the

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix buffer overruns in MSAA MCS buffer clearing.

2014-04-15 Thread Kenneth Graunke
On 04/15/2014 05:16 PM, Ian Romanick wrote: On 04/15/2014 03:50 PM, Kenneth Graunke wrote: On 04/15/2014 10:08 AM, Mike Stroyan wrote: I would go farther than requiring the returned bo-size to be covered by backing pages. There really should be backing pages for every page mapped by

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix buffer overruns in MSAA MCS buffer clearing.

2014-04-14 Thread Ian Romanick
On 04/14/2014 05:33 PM, Eric Anholt wrote: This manifested as rendering failures or sometimes GPU hangs in compositors when they accidentally got MSAA visuals due to a bug in the X Server. Today we decided that the problem in compositors was equivalent to a corruption bug we'd noticed