Re: [Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

2017-06-08 Thread Rob Herring
On Thu, Jun 8, 2017 at 3:06 AM, Tapani Pälli wrote: > > > On 06/08/2017 11:03 AM, Alex Smith wrote: >> >> Oops, sorry about that! > > > my bad, for me it actually compiles fine even with the ')' but there is > maybe some differences between mine and Rob's way of building

Re: [Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

2017-06-08 Thread Tapani Pälli
On 06/08/2017 11:03 AM, Alex Smith wrote: Oops, sorry about that! my bad, for me it actually compiles fine even with the ')' but there is maybe some differences between mine and Rob's way of building Mesa Alex On 8 June 2017 at 03:00, Rob Herring

Re: [Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

2017-06-08 Thread Alex Smith
Oops, sorry about that! Alex On 8 June 2017 at 03:00, Rob Herring wrote: > Commit 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to > src/vulkan/util") broke the Android build with the following error: > > build/core/binary.mk:1427: error:

Re: [Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

2017-06-07 Thread Tapani Pälli
argh, how did that get there ... Reviewed-by: Tapani Pälli On 06/08/2017 05:00 AM, Rob Herring wrote: Commit 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to src/vulkan/util") broke the Android build with the following error: build/core/binary.mk:1427: error:

[Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

2017-06-07 Thread Rob Herring
Commit 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to src/vulkan/util") broke the Android build with the following error: build/core/binary.mk:1427: error: external/mesa3d/src/vulkan/Android.mk: libmesa_vulkan_util: Unused source files: util/vk_util.h). Fixes: 621b3410f5f8 ("util/vulkan: