Re: [Mesa-dev] [PATCH] EGL: Combine the GL and GLES current contexts (v2)

2016-09-07 Thread Adam Jackson
On Wed, 2016-09-07 at 22:07 +0100, Emil Velikov wrote: > Was going to mention this but it slipped through. Can we get a proper > spec quote in the code ? I guess the logic through eglCreateContext (the only place where the API difference matters) is a little contorted, certainly took me more

Re: [Mesa-dev] [PATCH] EGL: Combine the GL and GLES current contexts (v2)

2016-09-07 Thread Emil Velikov
On 7 September 2016 at 16:57, Adam Jackson wrote: > On Wed, 2016-09-07 at 11:15 -0400, Adam Jackson wrote: >> From: Kyle Brenneman >> >> Only keep track of a single current context, instead of separate >> contexts for GL and GLES. > > In addition to fixing

Re: [Mesa-dev] [PATCH] EGL: Combine the GL and GLES current contexts (v2)

2016-09-07 Thread Chad Versace
On Wed 07 Sep 2016, Adam Jackson wrote: > On Wed, 2016-09-07 at 11:15 -0400, Adam Jackson wrote: > > From: Kyle Brenneman > > > > Only keep track of a single current context, instead of separate > > contexts for GL and GLES. > > In addition to fixing 1.4+ compliance, this

Re: [Mesa-dev] [PATCH] EGL: Combine the GL and GLES current contexts (v2)

2016-09-07 Thread Adam Jackson
On Wed, 2016-09-07 at 11:15 -0400, Adam Jackson wrote: > From: Kyle Brenneman > > Only keep track of a single current context, instead of separate > contexts for GL and GLES. In addition to fixing 1.4+ compliance, this fixes the "eglterminate then unbind context" piglit.

[Mesa-dev] [PATCH] EGL: Combine the GL and GLES current contexts (v2)

2016-09-07 Thread Adam Jackson
From: Kyle Brenneman Only keep track of a single current context, instead of separate contexts for GL and GLES. In EGL 1.4 (and 1.5), EGL_OPENGL_API and EGL_OPENGL_ES_API are supposed to be interchangeable for all purposes except for eglCreateContext. The