Re: [Mesa-dev] [PATCH] Revert "glsl: don't reference shader prog data during cache fallback"

2017-05-17 Thread Timothy Arceri
On 18/05/17 13:11, Timothy Arceri wrote: On 17/05/17 22:50, Nicolai Hähnle wrote: On 17.05.2017 14:26, Timothy Arceri wrote: On 17/05/17 22:03, Nicolai Hähnle wrote: On 17.05.2017 01:49, Timothy Arceri wrote: This might work for gallium based drivers but I'm pretty sure this will cause

Re: [Mesa-dev] [PATCH] Revert "glsl: don't reference shader prog data during cache fallback"

2017-05-17 Thread Timothy Arceri
On 17/05/17 22:50, Nicolai Hähnle wrote: On 17.05.2017 14:26, Timothy Arceri wrote: On 17/05/17 22:03, Nicolai Hähnle wrote: On 17.05.2017 01:49, Timothy Arceri wrote: This might work for gallium based drivers but I'm pretty sure this will cause problems for the i965 fallback path. What do

Re: [Mesa-dev] [PATCH] Revert "glsl: don't reference shader prog data during cache fallback"

2017-05-17 Thread Nicolai Hähnle
On 17.05.2017 14:26, Timothy Arceri wrote: On 17/05/17 22:03, Nicolai Hähnle wrote: On 17.05.2017 01:49, Timothy Arceri wrote: This might work for gallium based drivers but I'm pretty sure this will cause problems for the i965 fallback path. What do those problems look like? Sorry, I meant

Re: [Mesa-dev] [PATCH] Revert "glsl: don't reference shader prog data during cache fallback"

2017-05-17 Thread Timothy Arceri
On 17/05/17 22:03, Nicolai Hähnle wrote: On 17.05.2017 01:49, Timothy Arceri wrote: This might work for gallium based drivers but I'm pretty sure this will cause problems for the i965 fallback path. What do those problems look like? Sorry, I meant to add more details. The problem is that

Re: [Mesa-dev] [PATCH] Revert "glsl: don't reference shader prog data during cache fallback"

2017-05-17 Thread Nicolai Hähnle
On 17.05.2017 01:49, Timothy Arceri wrote: This might work for gallium based drivers but I'm pretty sure this will cause problems for the i965 fallback path. What do those problems look like? And any ideas on how to address the issue then? There are a number of places that assume

Re: [Mesa-dev] [PATCH] Revert "glsl: don't reference shader prog data during cache fallback"

2017-05-16 Thread Timothy Arceri
This might work for gallium based drivers but I'm pretty sure this will cause problems for the i965 fallback path. On 17/05/17 04:40, Nicolai Hähnle wrote: From: Nicolai Hähnle This reverts commit 0e9991f957e296f46cfff40a94ffba0adf2a58e1. At least when we fallback

[Mesa-dev] [PATCH] Revert "glsl: don't reference shader prog data during cache fallback"

2017-05-16 Thread Nicolai Hähnle
From: Nicolai Hähnle This reverts commit 0e9991f957e296f46cfff40a94ffba0adf2a58e1. At least when we fallback because of TGSI, the gl_program objects are re-allocated, and we don't in fact already have a reference to the gl_shader_program_data. This fixes a crash that