Re: [Mesa-dev] [PATCH] Revert "configure.ac: Disable compiler optimizations when --enable-debug is set"

2013-01-10 Thread Török Edwin
On 01/08/2013 10:17 PM, Kenneth Graunke wrote: > On 01/08/2013 12:06 PM, Matt Turner wrote: >> On Tue, Jan 8, 2013 at 8:38 AM, Marek Olšák wrote: >>> Some distributions use --enable-debug for testing packages and the commit >>> results in terrible CPU performance. It can be embarrassing for us. >>

Re: [Mesa-dev] [PATCH] Revert "configure.ac: Disable compiler optimizations when --enable-debug is set"

2013-01-10 Thread Marek Olšák
Maybe we should split --enable-debug into --enable-assertions and --enable-optimized. That's what LLVM does. Marek On Thu, Jan 10, 2013 at 4:03 AM, Chia-I Wu wrote: > On Wed, Jan 9, 2013 at 5:32 PM, Michel Dänzer wrote: >> On Die, 2013-01-08 at 09:31 -0800, Brian Paul wrote: >>> On 01/08/2013 0

Re: [Mesa-dev] [PATCH] Revert "configure.ac: Disable compiler optimizations when --enable-debug is set"

2013-01-09 Thread Chia-I Wu
On Wed, Jan 9, 2013 at 5:32 PM, Michel Dänzer wrote: > On Die, 2013-01-08 at 09:31 -0800, Brian Paul wrote: >> On 01/08/2013 08:38 AM, Marek Olšák wrote: >> > >> > Those who do not want optimizations should set the CFLAGS and CXXFLAGS >> > environment variables. In my opinion, --enable-debug shoul

Re: [Mesa-dev] [PATCH] Revert "configure.ac: Disable compiler optimizations when --enable-debug is set"

2013-01-09 Thread Brian Paul
On 01/09/2013 01:32 AM, Michel Dänzer wrote: On Die, 2013-01-08 at 09:31 -0800, Brian Paul wrote: On 01/08/2013 08:38 AM, Marek Olšák wrote: Those who do not want optimizations should set the CFLAGS and CXXFLAGS environment variables. In my opinion, --enable-debug should only set -DDEBUG. Pr

Re: [Mesa-dev] [PATCH] Revert "configure.ac: Disable compiler optimizations when --enable-debug is set"

2013-01-09 Thread Michel Dänzer
On Die, 2013-01-08 at 09:31 -0800, Brian Paul wrote: > On 01/08/2013 08:38 AM, Marek Olšák wrote: > > > > Those who do not want optimizations should set the CFLAGS and CXXFLAGS > > environment variables. In my opinion, --enable-debug should only set > > -DDEBUG. > > Previously, if we set --enabl

Re: [Mesa-dev] [PATCH] Revert "configure.ac: Disable compiler optimizations when --enable-debug is set"

2013-01-08 Thread Kenneth Graunke
On 01/08/2013 12:06 PM, Matt Turner wrote: On Tue, Jan 8, 2013 at 8:38 AM, Marek Olšák wrote: Some distributions use --enable-debug for testing packages and the commit results in terrible CPU performance. It can be embarrassing for us. If distros want debug symbols, they should put -g in thei

Re: [Mesa-dev] [PATCH] Revert "configure.ac: Disable compiler optimizations when --enable-debug is set"

2013-01-08 Thread Matt Turner
On Tue, Jan 8, 2013 at 8:38 AM, Marek Olšák wrote: > Some distributions use --enable-debug for testing packages and the commit > results in terrible CPU performance. It can be embarrassing for us. If distros want debug symbols, they should put -g in their CFLAGS instead of --enable-debug. --enabl

Re: [Mesa-dev] [PATCH] Revert "configure.ac: Disable compiler optimizations when --enable-debug is set"

2013-01-08 Thread Emil Velikov
On 08/01/13 17:27, Marek Olšák wrote: > On Tue, Jan 8, 2013 at 6:11 PM, Matt Turner wrote: >> On Tue, Jan 8, 2013 at 8:38 AM, Marek Olšák wrote: >>> This reverts commit 122345876479cf5cf553e38162ab105658614ab7. >>> >>> Some distributions use --enable-debug for testing packages and the commit >>>

Re: [Mesa-dev] [PATCH] Revert "configure.ac: Disable compiler optimizations when --enable-debug is set"

2013-01-08 Thread Eric Anholt
Marek Olšák writes: > I've had no problem with debugging even with -O2. Yeah, gdb cannot > show some variables sometimes, but I rarely had to force CFLAGS to -O0 > to debug an issue. That said, I can continue overriding CFLAGS and > CXXFLAGS like I do now if the majority of people think that > --

Re: [Mesa-dev] [PATCH] Revert "configure.ac: Disable compiler optimizations when --enable-debug is set"

2013-01-08 Thread Marek Olšák
I've had no problem with debugging even with -O2. Yeah, gdb cannot show some variables sometimes, but I rarely had to force CFLAGS to -O0 to debug an issue. That said, I can continue overriding CFLAGS and CXXFLAGS like I do now if the majority of people think that --disable-optimizations would be u

Re: [Mesa-dev] [PATCH] Revert "configure.ac: Disable compiler optimizations when --enable-debug is set"

2013-01-08 Thread Brian Paul
On 01/08/2013 08:38 AM, Marek Olšák wrote: This reverts commit 122345876479cf5cf553e38162ab105658614ab7. Some distributions use --enable-debug for testing packages and the commit results in terrible CPU performance. It can be embarrassing for us. Surely people should understand that enabling d

Re: [Mesa-dev] [PATCH] Revert "configure.ac: Disable compiler optimizations when --enable-debug is set"

2013-01-08 Thread Marek Olšák
On Tue, Jan 8, 2013 at 6:11 PM, Matt Turner wrote: > On Tue, Jan 8, 2013 at 8:38 AM, Marek Olšák wrote: >> This reverts commit 122345876479cf5cf553e38162ab105658614ab7. >> >> Some distributions use --enable-debug for testing packages and the commit >> results in terrible CPU performance. It can b

Re: [Mesa-dev] [PATCH] Revert "configure.ac: Disable compiler optimizations when --enable-debug is set"

2013-01-08 Thread Matt Turner
On Tue, Jan 8, 2013 at 8:38 AM, Marek Olšák wrote: > This reverts commit 122345876479cf5cf553e38162ab105658614ab7. > > Some distributions use --enable-debug for testing packages and the commit > results in terrible CPU performance. It can be embarrassing for us. > > Those who do not want optimizat

[Mesa-dev] [PATCH] Revert "configure.ac: Disable compiler optimizations when --enable-debug is set"

2013-01-08 Thread Marek Olšák
This reverts commit 122345876479cf5cf553e38162ab105658614ab7. Some distributions use --enable-debug for testing packages and the commit results in terrible CPU performance. It can be embarrassing for us. Those who do not want optimizations should set the CFLAGS and CXXFLAGS environment variables.