Re: [Mesa-dev] [PATCH] ac/nir: fix intrinsic names for atomic operations with LLVM 9+

2019-04-08 Thread Bas Nieuwenhuizen
r-b On Mon, Apr 8, 2019 at 12:36 PM Samuel Pitoiset wrote: > > > On 4/8/19 12:32 PM, Erik Faye-Lund wrote: > > On Mon, 2019-04-08 at 11:39 +0200, Samuel Pitoiset wrote: > >> This fixes the following LLVM error when using RADV_DEBUG=checkir: > >> Intrinsic name not mangled correctly for type

Re: [Mesa-dev] [PATCH] ac/nir: fix intrinsic names for atomic operations with LLVM 9+

2019-04-08 Thread Erik Faye-Lund
On Mon, 2019-04-08 at 12:39 +0200, Samuel Pitoiset wrote: > On 4/8/19 12:32 PM, Erik Faye-Lund wrote: > > On Mon, 2019-04-08 at 11:39 +0200, Samuel Pitoiset wrote: > > > This fixes the following LLVM error when using > > > RADV_DEBUG=checkir: > > > Intrinsic name not mangled correctly for type

Re: [Mesa-dev] [PATCH] ac/nir: fix intrinsic names for atomic operations with LLVM 9+

2019-04-08 Thread Samuel Pitoiset
On 4/8/19 12:32 PM, Erik Faye-Lund wrote: On Mon, 2019-04-08 at 11:39 +0200, Samuel Pitoiset wrote: This fixes the following LLVM error when using RADV_DEBUG=checkir: Intrinsic name not mangled correctly for type arguments! Should be: llvm.amdgcn.buffer.atomic.add.i32 i32 (i32, <4 x i32>, i32,

Re: [Mesa-dev] [PATCH] ac/nir: fix intrinsic names for atomic operations with LLVM 9+

2019-04-08 Thread Erik Faye-Lund
On Mon, 2019-04-08 at 11:39 +0200, Samuel Pitoiset wrote: > This fixes the following LLVM error when using RADV_DEBUG=checkir: > Intrinsic name not mangled correctly for type arguments! Should be: > llvm.amdgcn.buffer.atomic.add.i32 > i32 (i32, <4 x i32>, i32, i32, i1)*

[Mesa-dev] [PATCH] ac/nir: fix intrinsic names for atomic operations with LLVM 9+

2019-04-08 Thread Samuel Pitoiset
This fixes the following LLVM error when using RADV_DEBUG=checkir: Intrinsic name not mangled correctly for type arguments! Should be: llvm.amdgcn.buffer.atomic.add.i32 i32 (i32, <4 x i32>, i32, i32, i1)* @llvm.amdgcn.buffer.atomic.add The cmpswap operation still uses the old intrinsic.