Re: [Mesa-dev] [PATCH] ac/nir_to_llvm: fix interpolateAt* for arrays

2019-01-18 Thread Timothy Arceri
On 19/1/19 10:29 am, Bas Nieuwenhuizen wrote: On Sat, Jan 19, 2019 at 12:27 AM Bas Nieuwenhuizen wrote: On Sat, Jan 19, 2019 at 12:17 AM Timothy Arceri wrote: On 19/1/19 9:36 am, Bas Nieuwenhuizen wrote: On Thu, Jan 10, 2019 at 6:59 AM Timothy Arceri wrote: This builds on the recent

Re: [Mesa-dev] [PATCH] ac/nir_to_llvm: fix interpolateAt* for arrays

2019-01-18 Thread Bas Nieuwenhuizen
On Sat, Jan 19, 2019 at 12:27 AM Bas Nieuwenhuizen wrote: > On Sat, Jan 19, 2019 at 12:17 AM Timothy Arceri wrote: > > > > > > > > On 19/1/19 9:36 am, Bas Nieuwenhuizen wrote: > > > On Thu, Jan 10, 2019 at 6:59 AM Timothy Arceri > > > wrote: > > >> > > >> This builds on the recent interpolate

Re: [Mesa-dev] [PATCH] ac/nir_to_llvm: fix interpolateAt* for arrays

2019-01-18 Thread Bas Nieuwenhuizen
Fair, r-b On Sat, Jan 19, 2019 at 12:17 AM Timothy Arceri wrote: > > > > On 19/1/19 9:36 am, Bas Nieuwenhuizen wrote: > > On Thu, Jan 10, 2019 at 6:59 AM Timothy Arceri > > wrote: > >> > >> This builds on the recent interpolate fix by Rhys ee8488ea3b99. > >> > >> This doesn't handle arrays of

Re: [Mesa-dev] [PATCH] ac/nir_to_llvm: fix interpolateAt* for arrays

2019-01-18 Thread Timothy Arceri
On 19/1/19 9:36 am, Bas Nieuwenhuizen wrote: On Thu, Jan 10, 2019 at 6:59 AM Timothy Arceri wrote: This builds on the recent interpolate fix by Rhys ee8488ea3b99. This doesn't handle arrays of structs but I've got a feeling those might be broken even for radeonsi tgsi (we currently have no

Re: [Mesa-dev] [PATCH] ac/nir_to_llvm: fix interpolateAt* for arrays

2019-01-18 Thread Bas Nieuwenhuizen
On Thu, Jan 10, 2019 at 6:59 AM Timothy Arceri wrote: > > This builds on the recent interpolate fix by Rhys ee8488ea3b99. > > This doesn't handle arrays of structs but I've got a feeling those > might be broken even for radeonsi tgsi (we currently have no tests). > > This fixes the

Re: [Mesa-dev] [PATCH] ac/nir_to_llvm: fix interpolateAt* for arrays

2019-01-18 Thread Timothy Arceri
Ping! On 10/1/19 4:59 pm, Timothy Arceri wrote: This builds on the recent interpolate fix by Rhys ee8488ea3b99. This doesn't handle arrays of structs but I've got a feeling those might be broken even for radeonsi tgsi (we currently have no tests). This fixes the arb_gpu_shader5 interpolateAt*

[Mesa-dev] [PATCH] ac/nir_to_llvm: fix interpolateAt* for arrays

2019-01-09 Thread Timothy Arceri
This builds on the recent interpolate fix by Rhys ee8488ea3b99. This doesn't handle arrays of structs but I've got a feeling those might be broken even for radeonsi tgsi (we currently have no tests). This fixes the arb_gpu_shader5 interpolateAt* tests that contain arrays. Fixes: ee8488ea3b99