Re: [Mesa-dev] [PATCH] amd: Make vgpr-spilling depend on llvm version
Reviewed-by: Samuel Pitoiset On 11/1/18 7:52 PM, Jan Vesely wrote: The option was removed in LLVM r345763 Signed-off-by: Jan Vesely --- src/amd/common/ac_llvm_util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_util.c b/src/amd/common/ac_llvm_util.c index 69d9f7b9f3..dc9b684e9d 100644 --- a/src/amd/common/ac_llvm_util.c +++ b/src/amd/common/ac_llvm_util.c @@ -153,7 +153,8 @@ static LLVMTargetMachineRef ac_create_target_machine(enum radeon_family family, LLVMTargetRef target = ac_get_llvm_target(triple); snprintf(features, sizeof(features), - "+DumpCode,+vgpr-spilling,-fp32-denormals,+fp64-denormals%s%s%s%s", +"+DumpCode,-fp32-denormals,+fp64-denormals%s%s%s%s%s", +HAVE_LLVM >= 0x0800 ? "" : ",+vgpr-spilling", tm_options & AC_TM_SISCHED ? ",+si-scheduler" : "", tm_options & AC_TM_FORCE_ENABLE_XNACK ? ",+xnack" : "", tm_options & AC_TM_FORCE_DISABLE_XNACK ? ",-xnack" : "", ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] amd: Make vgpr-spilling depend on llvm version
Tested-by: Dieter Nützel Thanks! Dieter Am 01.11.2018 19:52, schrieb Jan Vesely: The option was removed in LLVM r345763 Signed-off-by: Jan Vesely --- src/amd/common/ac_llvm_util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_util.c b/src/amd/common/ac_llvm_util.c index 69d9f7b9f3..dc9b684e9d 100644 --- a/src/amd/common/ac_llvm_util.c +++ b/src/amd/common/ac_llvm_util.c @@ -153,7 +153,8 @@ static LLVMTargetMachineRef ac_create_target_machine(enum radeon_family family, LLVMTargetRef target = ac_get_llvm_target(triple); snprintf(features, sizeof(features), - "+DumpCode,+vgpr-spilling,-fp32-denormals,+fp64-denormals%s%s%s%s", +"+DumpCode,-fp32-denormals,+fp64-denormals%s%s%s%s%s", +HAVE_LLVM >= 0x0800 ? "" : ",+vgpr-spilling", tm_options & AC_TM_SISCHED ? ",+si-scheduler" : "", tm_options & AC_TM_FORCE_ENABLE_XNACK ? ",+xnack" : "", tm_options & AC_TM_FORCE_DISABLE_XNACK ? ",-xnack" : "", ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] amd: Make vgpr-spilling depend on llvm version
Reviewed-by: Marek Olšák Marek On Thu, Nov 1, 2018 at 2:52 PM Jan Vesely wrote: > The option was removed in LLVM r345763 > Signed-off-by: Jan Vesely > --- > src/amd/common/ac_llvm_util.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/amd/common/ac_llvm_util.c b/src/amd/common/ac_llvm_util.c > index 69d9f7b9f3..dc9b684e9d 100644 > --- a/src/amd/common/ac_llvm_util.c > +++ b/src/amd/common/ac_llvm_util.c > @@ -153,7 +153,8 @@ static LLVMTargetMachineRef > ac_create_target_machine(enum radeon_family family, > LLVMTargetRef target = ac_get_llvm_target(triple); > > snprintf(features, sizeof(features), > - > "+DumpCode,+vgpr-spilling,-fp32-denormals,+fp64-denormals%s%s%s%s", > +"+DumpCode,-fp32-denormals,+fp64-denormals%s%s%s%s%s", > +HAVE_LLVM >= 0x0800 ? "" : ",+vgpr-spilling", > tm_options & AC_TM_SISCHED ? ",+si-scheduler" : "", > tm_options & AC_TM_FORCE_ENABLE_XNACK ? ",+xnack" : "", > tm_options & AC_TM_FORCE_DISABLE_XNACK ? ",-xnack" : "", > -- > 2.19.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] amd: Make vgpr-spilling depend on llvm version
The option was removed in LLVM r345763 Signed-off-by: Jan Vesely --- src/amd/common/ac_llvm_util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_util.c b/src/amd/common/ac_llvm_util.c index 69d9f7b9f3..dc9b684e9d 100644 --- a/src/amd/common/ac_llvm_util.c +++ b/src/amd/common/ac_llvm_util.c @@ -153,7 +153,8 @@ static LLVMTargetMachineRef ac_create_target_machine(enum radeon_family family, LLVMTargetRef target = ac_get_llvm_target(triple); snprintf(features, sizeof(features), - "+DumpCode,+vgpr-spilling,-fp32-denormals,+fp64-denormals%s%s%s%s", +"+DumpCode,-fp32-denormals,+fp64-denormals%s%s%s%s%s", +HAVE_LLVM >= 0x0800 ? "" : ",+vgpr-spilling", tm_options & AC_TM_SISCHED ? ",+si-scheduler" : "", tm_options & AC_TM_FORCE_ENABLE_XNACK ? ",+xnack" : "", tm_options & AC_TM_FORCE_DISABLE_XNACK ? ",-xnack" : "", -- 2.19.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
