Re: [Mesa-dev] [PATCH] anv: Bump maxComputeWorkgroupInvocations

[Lionel Landwerlin]

Reviewed-by: Lionel Landwerlin 

On 19/03/2019 17:08, Jason Ekstrand wrote:

We initially set this lower because we didn't have SIMD32 support yet
but we've supported SIMD32 for quite some time now.  We should bump it
up to the real limit.
---
  src/intel/vulkan/anv_device.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index a6ecc657f4b..7ba2e802c25 100644
--- a/src/intel/vulkan/anv_device.c
+++ b/src/intel/vulkan/anv_device.c
@@ -1132,7 +1132,7 @@ void anv_GetPhysicalDeviceProperties(
.maxFragmentCombinedOutputResources   = 8,
.maxComputeSharedMemorySize   = 32768,
.maxComputeWorkGroupCount = { 65535, 65535, 65535 },
-  .maxComputeWorkGroupInvocations   = 16 * devinfo->max_cs_threads,
+  .maxComputeWorkGroupInvocations   = 32 * devinfo->max_cs_threads,
.maxComputeWorkGroupSize = {
   16 * devinfo->max_cs_threads,
   16 * devinfo->max_cs_threads,



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] anv: Bump maxComputeWorkgroupInvocations

[Jason Ekstrand]

We initially set this lower because we didn't have SIMD32 support yet
but we've supported SIMD32 for quite some time now.  We should bump it
up to the real limit.
---
 src/intel/vulkan/anv_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index a6ecc657f4b..7ba2e802c25 100644
--- a/src/intel/vulkan/anv_device.c
+++ b/src/intel/vulkan/anv_device.c
@@ -1132,7 +1132,7 @@ void anv_GetPhysicalDeviceProperties(
   .maxFragmentCombinedOutputResources   = 8,
   .maxComputeSharedMemorySize   = 32768,
   .maxComputeWorkGroupCount = { 65535, 65535, 65535 },
-  .maxComputeWorkGroupInvocations   = 16 * devinfo->max_cs_threads,
+  .maxComputeWorkGroupInvocations   = 32 * devinfo->max_cs_threads,
   .maxComputeWorkGroupSize = {
  16 * devinfo->max_cs_threads,
  16 * devinfo->max_cs_threads,
-- 
2.20.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev