Re: [Mesa-dev] [PATCH] anv: Disable __gen_validate_value if NDEBUG is set.

2018-06-21 Thread Eric Anholt
Kenneth Graunke writes: > We were enabling undefined memory checking for genxml values based on > Valgrind being installed at build time, even for release builds. This > generates piles and piles of assembly whenever you touch genxml. > > With gcc 7.3.1 and -O3 and -march=native on a Kabylake

Re: [Mesa-dev] [PATCH] anv: Disable __gen_validate_value if NDEBUG is set.

2018-06-08 Thread Kenneth Graunke
On Thursday, June 7, 2018 4:46:24 PM PDT Jason Ekstrand wrote: > On Thu, Jun 7, 2018 at 4:02 PM, Kenneth Graunke > wrote: > > > We were enabling undefined memory checking for genxml values based on > > Valgrind being installed at build time, even for release builds. This > > generates piles and

Re: [Mesa-dev] [PATCH] anv: Disable __gen_validate_value if NDEBUG is set.

2018-06-07 Thread Jason Ekstrand
On Thu, Jun 7, 2018 at 4:02 PM, Kenneth Graunke wrote: > We were enabling undefined memory checking for genxml values based on > Valgrind being installed at build time, even for release builds. This > generates piles and piles of assembly whenever you touch genxml. > > With gcc 7.3.1 and -O3

[Mesa-dev] [PATCH] anv: Disable __gen_validate_value if NDEBUG is set.

2018-06-07 Thread Kenneth Graunke
We were enabling undefined memory checking for genxml values based on Valgrind being installed at build time, even for release builds. This generates piles and piles of assembly whenever you touch genxml. With gcc 7.3.1 and -O3 and -march=native on a Kabylake with Valgrind installed at build