Re: [Mesa-dev] [PATCH] anv: Explicitly set 3DSTATE_CLIP::VertexSubPixelPrecisionSelect

2019-02-22 Thread Lionel Landwerlin

On 22/02/2019 16:02, Jason Ekstrand wrote:

This field was added on gen8 even though there's an identically defined
one in 3DSTATE_SF.
---
  src/intel/vulkan/genX_pipeline.c | 4 
  1 file changed, 4 insertions(+)

diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c
index 6255e5d83c5..192a121324d 100644
--- a/src/intel/vulkan/genX_pipeline.c
+++ b/src/intel/vulkan/genX_pipeline.c
@@ -1077,6 +1077,10 @@ emit_3dstate_clip(struct anv_pipeline *pipeline,
clip.APIMode  = APIMODE_D3D,
clip.ViewportXYClipTestEnable = true;
  
+#if GEN_GEN >= 8

+  clip.VertexSubPixelPrecisionSelect = _8Bit;
+#endif
+
clip.ClipMode = CLIPMODE_NORMAL;
  
clip.TriangleStripListProvokingVertexSelect = 0;



Well spotted.


Reviewed-by: Lionel Landwerlin 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] anv: Explicitly set 3DSTATE_CLIP::VertexSubPixelPrecisionSelect

2019-02-22 Thread Jason Ekstrand
This field was added on gen8 even though there's an identically defined
one in 3DSTATE_SF.
---
 src/intel/vulkan/genX_pipeline.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c
index 6255e5d83c5..192a121324d 100644
--- a/src/intel/vulkan/genX_pipeline.c
+++ b/src/intel/vulkan/genX_pipeline.c
@@ -1077,6 +1077,10 @@ emit_3dstate_clip(struct anv_pipeline *pipeline,
   clip.APIMode  = APIMODE_D3D,
   clip.ViewportXYClipTestEnable = true;
 
+#if GEN_GEN >= 8
+  clip.VertexSubPixelPrecisionSelect = _8Bit;
+#endif
+
   clip.ClipMode = CLIPMODE_NORMAL;
 
   clip.TriangleStripListProvokingVertexSelect = 0;
-- 
2.20.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev