Re: [Mesa-dev] [PATCH] anv: Remove base_vertex/instance from push_constants

[Lionel Landwerlin]

Reviewed-by: Lionel Landwerlin 

On 28/09/17 01:02, Jason Ekstrand wrote:

This is just legacy cruft.  We don't push these values; we pass them in
as vertex attributes.
---
  src/intel/vulkan/anv_private.h | 7 ---
  1 file changed, 7 deletions(-)

diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index 3ba623a..b58c803 100644
--- a/src/intel/vulkan/anv_private.h
+++ b/src/intel/vulkan/anv_private.h
@@ -1560,13 +1560,6 @@ struct anv_push_constants {
 /* Push constant data provided by the client through vkPushConstants */
 uint8_t client_data[MAX_PUSH_CONSTANTS_SIZE];
  
-   /* Our hardware only provides zero-based vertex and instance id so, in

-* order to satisfy the vulkan requirements, we may have to push one or
-* both of these into the shader.
-*/
-   uint32_t base_vertex;
-   uint32_t base_instance;
-
 /* Image data for image_load_store on pre-SKL */
 struct brw_image_param images[MAX_IMAGES];
  };



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] anv: Remove base_vertex/instance from push_constants

[Jason Ekstrand]

This is just legacy cruft.  We don't push these values; we pass them in
as vertex attributes.
---
 src/intel/vulkan/anv_private.h | 7 ---
 1 file changed, 7 deletions(-)

diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index 3ba623a..b58c803 100644
--- a/src/intel/vulkan/anv_private.h
+++ b/src/intel/vulkan/anv_private.h
@@ -1560,13 +1560,6 @@ struct anv_push_constants {
/* Push constant data provided by the client through vkPushConstants */
uint8_t client_data[MAX_PUSH_CONSTANTS_SIZE];
 
-   /* Our hardware only provides zero-based vertex and instance id so, in
-* order to satisfy the vulkan requirements, we may have to push one or
-* both of these into the shader.
-*/
-   uint32_t base_vertex;
-   uint32_t base_instance;
-
/* Image data for image_load_store on pre-SKL */
struct brw_image_param images[MAX_IMAGES];
 };
-- 
2.5.0.400.gff86faf

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev