Re: [Mesa-dev] [PATCH] anv: bump push constant max size to 512bytes

2017-06-12 Thread Lionel Landwerlin
I think Ken is looking at some optimizations around push constants. Maybe his work will replace this patch. Any comment Ken? Cheers, - Lionel On 12/06/17 14:44, Alejandro Piñeiro wrote: Gentle ping. We have a patch, and a review, but it is not on master yet. An oversight? Is there any

Re: [Mesa-dev] [PATCH] anv: bump push constant max size to 512bytes

2017-06-12 Thread Alejandro Piñeiro
Gentle ping. We have a patch, and a review, but it is not on master yet. An oversight? Is there any reason to not have pushed it to master? Thanks BR On 27/03/17 14:59, Eduardo Lima Mitev wrote: > We have hit this limit too while working on an upcoming Vulkan > extension. Increasing the push

Re: [Mesa-dev] [PATCH] anv: bump push constant max size to 512bytes

2017-03-27 Thread Eduardo Lima Mitev
We have hit this limit too while working on an upcoming Vulkan extension. Increasing the push constants area to 512 seems sensible and safe. I also checked on CI that this brings no regressions. This patch needs a trivial rebase fix, otherwise it is: Reviewed-by: Eduardo Lima Mitev

[Mesa-dev] [PATCH] anv: bump push constant max size to 512bytes

2016-12-02 Thread Lionel Landwerlin
This is the size selected by the i965 driver. Signed-off-by: Lionel Landwerlin Cc: Kenneth Graunke --- src/intel/vulkan/anv_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_private.h