Re: [Mesa-dev] [PATCH] automake: r600: radeonsi: correctly manage libamd_common.la linking

2017-03-01 Thread Emil Velikov
On 1 March 2017 at 03:49, Michel Dänzer wrote: > On 28/02/17 08:08 PM, Emil Velikov wrote: >> From: Emil Velikov >> >> Since both r600 and radeonsi use code from libamd_common they need to >> static link it. At the same time, adding a common

Re: [Mesa-dev] [PATCH] automake: r600: radeonsi: correctly manage libamd_common.la linking

2017-02-28 Thread Michel Dänzer
On 28/02/17 08:08 PM, Emil Velikov wrote: > From: Emil Velikov > > Since both r600 and radeonsi use code from libamd_common they need to > static link it. At the same time, adding a common library to LIB_DEPS is > fragile [can lean to multiple symbol definitions] and

Re: [Mesa-dev] [PATCH] automake: r600: radeonsi: correctly manage libamd_common.la linking

2017-02-28 Thread Marek Olšák
Acked-by: Marek Olšák Marek On Tue, Feb 28, 2017 at 12:08 PM, Emil Velikov wrote: > From: Emil Velikov > > Since both r600 and radeonsi use code from libamd_common they need to > static link it. At the same time,

[Mesa-dev] [PATCH] automake: r600: radeonsi: correctly manage libamd_common.la linking

2017-02-28 Thread Emil Velikov
From: Emil Velikov Since both r600 and radeonsi use code from libamd_common they need to static link it. At the same time, adding a common library to LIB_DEPS is fragile [can lean to multiple symbol definitions] and non-obvious - I had to do a double-take how things