Re: [Mesa-dev] [PATCH] build: fix --without-glut
On Tuesday, 20 November 2012 at 21:48, Brian Paul wrote: Personally, I trust Kilgard's GLUT more freeglut. Some versions of freeglut (hopefully fixed by now but I don't know) spend an inordinate amount of time in a InitSpaceBall() function, with a significant FPS hit. Another problem I've seen is the first window draw happens twice instead of once (even when not animating). I've seen GL bugs where the first frame drawn has a glitch but the second frame is fine. That kind of bug is hard to spot if you always draw twice. And FWIW, just because a project hasn't had recent commits doesn't mean it's bad software. It's really just _done_. I'll admit to semi-trolling - if Mesa's GLUT is considered finished and not abandoned, then I'll happily switch to Mesa's GLUT over FreeGLUT for the simple reason that we're already using Mesa and Mesa's GLU. Ross ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] build: fix --without-glut
On Tue, Nov 20, 2012 at 1:52 PM, Ross Burton ross.bur...@intel.com wrote: On Tuesday, 20 November 2012 at 21:48, Brian Paul wrote: Personally, I trust Kilgard's GLUT more freeglut. Some versions of freeglut (hopefully fixed by now but I don't know) spend an inordinate amount of time in a InitSpaceBall() function, with a significant FPS hit. Another problem I've seen is the first window draw happens twice instead of once (even when not animating). I've seen GL bugs where the first frame drawn has a glitch but the second frame is fine. That kind of bug is hard to spot if you always draw twice. And FWIW, just because a project hasn't had recent commits doesn't mean it's bad software. It's really just _done_. I'll admit to semi-trolling - if Mesa's GLUT is considered finished and not abandoned, then I'll happily switch to Mesa's GLUT over FreeGLUT for the simple reason that we're already using Mesa and Mesa's GLU. To be clear, Mesa's GLU was a thing, but it is not this thing: http://cgit.freedesktop.org/mesa/glu That's SGI's GLU. I hope you're not using Mesa's GLU. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] build: fix --without-glut
On 21 November 2012 08:27, Matt Turner matts...@gmail.com wrote: To be clear, Mesa's GLU was a thing, but it is not this thing: http://cgit.freedesktop.org/mesa/glu That's SGI's GLU. I hope you're not using Mesa's GLU. Ah, thanks. Yes, I'm using that repository. Ross ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] build: fix --without-glut
On 14 November 2012 15:38, Dan Nicholson dbn.li...@gmail.com wrote: This looks pretty good except that I think you need to temporarily add GLUT_CFLAGS to CFLAGS and GLUT_LIBS to LIBS so that the user specified prefix works for AC_CHECK*. On the other hand, at least mesa glut has a pkg-config file, so it might be easier to just require a glut with glut.pc. Not sure about the other gluts though. Yes, I think you're right about AC_CHECK, I'll fix that. FreeGLUT at least doesn't ship glut.pc. We could drop freeglut for mesa/glut but then it's had commits in the last three years, unlike mesa/glut... Undecided. Ross ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] build: fix --without-glut
On 11/20/2012 08:57 AM, Burton, Ross wrote: On 14 November 2012 15:38, Dan Nicholson dbn.li...@gmail.com wrote: This looks pretty good except that I think you need to temporarily add GLUT_CFLAGS to CFLAGS and GLUT_LIBS to LIBS so that the user specified prefix works for AC_CHECK*. On the other hand, at least mesa glut has a pkg-config file, so it might be easier to just require a glut with glut.pc. Not sure about the other gluts though. Yes, I think you're right about AC_CHECK, I'll fix that. FreeGLUT at least doesn't ship glut.pc. We could drop freeglut for mesa/glut but then it's had commits in the last three years, unlike mesa/glut... Undecided. Ross My advice: don't use Kilgard's GLUT. It would be nice if freeglut shipped a .pc file though. --Ken ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] build: fix --without-glut
On Tue, Nov 20, 2012 at 3:34 PM, Kenneth Graunke kenn...@whitecape.org wrote: On 11/20/2012 08:57 AM, Burton, Ross wrote: On 14 November 2012 15:38, Dan Nicholson dbn.li...@gmail.com wrote: This looks pretty good except that I think you need to temporarily add GLUT_CFLAGS to CFLAGS and GLUT_LIBS to LIBS so that the user specified prefix works for AC_CHECK*. On the other hand, at least mesa glut has a pkg-config file, so it might be easier to just require a glut with glut.pc. Not sure about the other gluts though. Yes, I think you're right about AC_CHECK, I'll fix that. FreeGLUT at least doesn't ship glut.pc. We could drop freeglut for mesa/glut but then it's had commits in the last three years, unlike mesa/glut... Undecided. Ross My advice: don't use Kilgard's GLUT. It would be nice if freeglut shipped a .pc file though. Personally, I trust Kilgard's GLUT more freeglut. Some versions of freeglut (hopefully fixed by now but I don't know) spend an inordinate amount of time in a InitSpaceBall() function, with a significant FPS hit. Another problem I've seen is the first window draw happens twice instead of once (even when not animating). I've seen GL bugs where the first frame drawn has a glitch but the second frame is fine. That kind of bug is hard to spot if you always draw twice. And FWIW, just because a project hasn't had recent commits doesn't mean it's bad software. It's really just _done_. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] build: fix --without-glut
On Nov 13, 2012 11:09 PM, Ross Burton ross.bur...@intel.com wrote: The argument --without-glut is transformed to --with-glut=no, which the logic wasn't handling at all so --without-glut didn't work. Rewrite the logic to handle the case where the value passed to --with-glut is no. Signed-off-by: Ross Burton ross.bur...@intel.com --- configure.ac | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index 8b2c359..fda3e60 100644 --- a/configure.ac +++ b/configure.ac @@ -67,21 +67,25 @@ DEMO_CFLAGS=$DEMO_CFLAGS $GL_CFLAGS DEMO_LIBS=$DEMO_LIBS $GL_LIBS dnl Check for GLUT -GLUT_CFLAGS= -GLUT_LIBS=-lglut -glut_enabled=yes +glut_enabled=no AC_ARG_WITH([glut], [AS_HELP_STRING([--with-glut=DIR], [glut install directory])], [GLUT_CFLAGS=-I$withval/include -GLUT_LIBS=-L$withval/lib -lglut]) -AC_CHECK_HEADER([GL/glut.h], - [], - [glut_enabled=no]) -AC_CHECK_LIB([glut], - [glutInit], - [], - [glut_enabled=no]) +GLUT_LIBS=-L$withval/lib -lglut], + [GLUT_CFLAGS= +GLUT_LIBS=-lglut] +) +AS_IF([test x$with_glut != xno], + [AC_CHECK_HEADER([GL/glut.h], + [], + [glut_enabled=no]) + AC_CHECK_LIB([glut], +[glutInit], +[], +[glut_enabled=no]) + glut_enabled=yes +]) This looks pretty good except that I think you need to temporarily add GLUT_CFLAGS to CFLAGS and GLUT_LIBS to LIBS so that the user specified prefix works for AC_CHECK*. On the other hand, at least mesa glut has a pkg-config file, so it might be easier to just require a glut with glut.pc. Not sure about the other gluts though. Dan ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] build: fix --without-glut
The argument --without-glut is transformed to --with-glut=no, which the logic wasn't handling at all so --without-glut didn't work. Rewrite the logic to handle the case where the value passed to --with-glut is no. Signed-off-by: Ross Burton ross.bur...@intel.com --- configure.ac | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index 8b2c359..fda3e60 100644 --- a/configure.ac +++ b/configure.ac @@ -67,21 +67,25 @@ DEMO_CFLAGS=$DEMO_CFLAGS $GL_CFLAGS DEMO_LIBS=$DEMO_LIBS $GL_LIBS dnl Check for GLUT -GLUT_CFLAGS= -GLUT_LIBS=-lglut -glut_enabled=yes +glut_enabled=no AC_ARG_WITH([glut], [AS_HELP_STRING([--with-glut=DIR], [glut install directory])], [GLUT_CFLAGS=-I$withval/include -GLUT_LIBS=-L$withval/lib -lglut]) -AC_CHECK_HEADER([GL/glut.h], - [], - [glut_enabled=no]) -AC_CHECK_LIB([glut], - [glutInit], - [], - [glut_enabled=no]) +GLUT_LIBS=-L$withval/lib -lglut], + [GLUT_CFLAGS= +GLUT_LIBS=-lglut] +) +AS_IF([test x$with_glut != xno], + [AC_CHECK_HEADER([GL/glut.h], + [], + [glut_enabled=no]) + AC_CHECK_LIB([glut], +[glutInit], +[], +[glut_enabled=no]) + glut_enabled=yes +]) dnl Check for GLEW PKG_CHECK_MODULES(GLEW, [glew = 1.5.4]) -- 1.7.10.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
