Re: [Mesa-dev] [PATCH] draw: make sure key size is calculated consistently.

2013-02-21 Thread Jose Fonseca
Looks perfect. Thanks Roland. Jose - Original Message - From: Roland Scheidegger srol...@vmware.com Some parts calculated key size by using shader information, others by using the pipe_vertex_element information. Since it is perfectly valid to have more vertex_elements set than

Re: [Mesa-dev] [PATCH] draw: make sure key size is calculated consistently.

2013-02-19 Thread Brian Paul
On 02/18/2013 05:27 PM, srol...@vmware.com wrote: From: Roland Scheideggersrol...@vmware.com Some parts calculated key size by using shader information, others by using the pipe_vertex_element information. Since it is perfectly valid to have more vertex_elements set than the vertex shader is

Re: [Mesa-dev] [PATCH] draw: make sure key size is calculated consistently.

2013-02-19 Thread Jose Fonseca
There may be more vertex elements that used in the shader. But why should the key contain those elements? Won't this cause needless recompilations (e.g., in situations where the state tracker leaves unneeded elements from previous draw?)? That is, it seems to be that the key should have the

Re: [Mesa-dev] [PATCH] draw: make sure key size is calculated consistently.

2013-02-19 Thread Roland Scheidegger
Am 19.02.2013 15:57, schrieb Jose Fonseca: There may be more vertex elements that used in the shader. But why should the key contain those elements? Won't this cause needless recompilations (e.g., in situations where the state tracker leaves unneeded elements from previous draw?)? I don't

Re: [Mesa-dev] [PATCH] draw: make sure key size is calculated consistently.

2013-02-19 Thread Jose Fonseca
- Original Message - Am 19.02.2013 15:57, schrieb Jose Fonseca: There may be more vertex elements that used in the shader. But why should the key contain those elements? Won't this cause needless recompilations (e.g., in situations where the state tracker leaves unneeded elements

Re: [Mesa-dev] [PATCH] draw: make sure key size is calculated consistently.

2013-02-19 Thread Roland Scheidegger
Am 19.02.2013 18:54, schrieb Jose Fonseca: - Original Message - Am 19.02.2013 15:57, schrieb Jose Fonseca: There may be more vertex elements that used in the shader. But why should the key contain those elements? Won't this cause needless recompilations (e.g., in situations where

[Mesa-dev] [PATCH] draw: make sure key size is calculated consistently.

2013-02-19 Thread sroland
From: Roland Scheidegger srol...@vmware.com Some parts calculated key size by using shader information, others by using the pipe_vertex_element information. Since it is perfectly valid to have more vertex_elements set than the vertex shader is using those may not be the same, so we weren't

[Mesa-dev] [PATCH] draw: make sure key size is calculated consistently.

2013-02-18 Thread sroland
From: Roland Scheidegger srol...@vmware.com Some parts calculated key size by using shader information, others by using the pipe_vertex_element information. Since it is perfectly valid to have more vertex_elements set than the vertex shader is using those may not be the same, so we weren't