Re: [Mesa-dev] [PATCH] egl: avoid eglCreatePlatform*Surface{EXT, } crash with invalid dpy

2017-08-09 Thread Tapani Pälli
Yeah, _eglLookupDisplay seems to return NULL indeed in this case; Reviewed-by: Tapani Pälli On 08/08/2017 05:55 PM, Emil Velikov wrote: From: Emil Velikov If we have an invalid display fed into the functions, the display lookup will return NULL. Thus as we attempt to get the platform type,

Re: [Mesa-dev] [PATCH] egl: avoid eglCreatePlatform*Surface{EXT, } crash with invalid dpy

2017-08-09 Thread Eric Engestrom
On Tuesday, 2017-08-08 15:55:36 +0100, Emil Velikov wrote: > From: Emil Velikov > > If we have an invalid display fed into the functions, the display lookup > will return NULL. Thus as we attempt to get the platform type, we'll > deref. it leading to a crash. > > Keep in mind that this will not

[Mesa-dev] [PATCH] egl: avoid eglCreatePlatform*Surface{EXT, } crash with invalid dpy

2017-08-08 Thread Emil Velikov
From: Emil Velikov If we have an invalid display fed into the functions, the display lookup will return NULL. Thus as we attempt to get the platform type, we'll deref. it leading to a crash. Keep in mind that this will not happen if Mesa is built without X11 or when the legacy eglCreate*Surface