Re: [Mesa-dev] [PATCH] egl: define NULL in egldevice.h

2018-11-28 Thread Emil Velikov
On Wed, 28 Nov 2018 at 12:33, Eric Engestrom wrote: > > On Tuesday, 2018-11-27 22:52:47 -0800, Matt Turner wrote: > > Reviewed-by: Matt Turner > > > > I'll commit it tomorrow. > > When you do that, the commit title should be fixed to something like > egl: add missing #include in egldevice.h >

Re: [Mesa-dev] [PATCH] egl: define NULL in egldevice.h

2018-11-28 Thread Eric Engestrom
On Tuesday, 2018-11-27 22:52:47 -0800, Matt Turner wrote: > Reviewed-by: Matt Turner > > I'll commit it tomorrow. When you do that, the commit title should be fixed to something like egl: add missing #include in egldevice.h since the original commit title doesn't apply anymore. And while at

Re: [Mesa-dev] [PATCH] egl: define NULL in egldevice.h

2018-11-27 Thread Matt Turner
Reviewed-by: Matt Turner I'll commit it tomorrow. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] egl: define NULL in egldevice.h

2018-11-27 Thread Gurchetan Singh
Otherwise, I get this error: main/egldevice.h:54:13: error: ‘NULL’ undeclared (first use in this function) dev = NULL; ^~~~ with this config: ./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless' --disable-glx --with-dri-drivers="i965"

Re: [Mesa-dev] [PATCH] egl: define NULL in egldevice.h

2018-11-27 Thread Matt Turner
Wouldn't it be better to just include the stdlib.h/stddef.h header that defines NULL? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] egl: define NULL in egldevice.h

2018-11-27 Thread Gurchetan Singh
Otherwise, I get this error: main/egldevice.h:54:13: error: ‘NULL’ undeclared (first use in this function) dev = NULL; ^~~~ with this config: ./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless' --disable-glx --with-dri-drivers="i965"

[Mesa-dev] [PATCH] egl: define NULL in egldevice.h

2018-11-27 Thread Gurchetan Singh
Otherwise, I get this error: main/egldevice.h:54:13: error: ‘NULL’ undeclared (first use in this function) dev = NULL; ^~~~ with this config: ./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless' --disable-glx --with-dri-drivers="i965"