Re: [Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

2017-05-02 Thread Lin, Johnson
Thanks for the comments and have updated the patch! -Original Message- From: Matt Turner [mailto:matts...@gmail.com] Sent: Wednesday, May 3, 2017 2:37 AM To: Lin, Johnson <johnson@intel.com> Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] fix minor error in Y

Re: [Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

2017-05-02 Thread Matt Turner
On Tue, May 2, 2017 at 7:24 AM, Johnson Lin wrote: > The matrix used for YCbCr to RGB is listed in Wiki https://en.wikipedia.org/ > wiki/YCbCr; There is minor error in the matrix constant: 0.0625=16/256 should > be 16.0/255,and 0.5=128.0/256 should be 128.0/255. > Note

Re: [Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

2017-05-02 Thread Eric Anholt
"Kristian H. Kristensen" writes: > Johnson Lin writes: > >> The matrix used for YCbCr to RGB is listed in Wiki >> https://en.wikipedia.org/wiki/YCbCr; >> There is minor error in the matrix constant: 0.0625=16/256 should be >> 16.0/255, >> and

Re: [Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

2017-05-02 Thread Jason Ekstrand
Please prefix with "nir/lower_tex:" How about nir/lower_tex: Fix minor error in YUV color conversion matrix On Tue, May 2, 2017 at 7:24 AM, Johnson Lin wrote: > The matrix used for YCbCr to RGB is listed in Wiki > https://en.wikipedia.org/ > wiki/YCbCr; There is minor

[Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

2017-05-02 Thread Johnson Lin
The matrix used for YCbCr to RGB is listed in Wiki https://en.wikipedia.org/ wiki/YCbCr; There is minor error in the matrix constant: 0.0625=16/256 should be 16.0/255,and 0.5=128.0/256 should be 128.0/255. Note that conversion from a 0-255 byte number to 0-1.0 float is to divide by 255 instead of

Re: [Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

2017-05-01 Thread Kristian H. Kristensen
Johnson Lin writes: > The matrix used for YCbCr to RGB is listed in Wiki > https://en.wikipedia.org/wiki/YCbCr; > There is minor error in the matrix constant: 0.0625=16/256 should be 16.0/255, > and 0.5=128.0/256 should be 128.0/255. > Note that conversion from a 0-255

[Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

2017-04-28 Thread Johnson Lin
The matrix used for YCbCr to RGB is listed in Wiki https://en.wikipedia.org/wiki/YCbCr; There is minor error in the matrix constant: 0.0625=16/256 should be 16.0/255, and 0.5=128.0/256 should be 128.0/255. Note that conversion from a 0-255 byte number to 0-1.0 float is to divide by 255 instead

Re: [Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

2017-04-28 Thread Lin, Johnson
Yes, We can. Will do it -Original Message- From: Eric Anholt [mailto:e...@anholt.net] Sent: Saturday, April 29, 2017 6:02 AM To: Lin, Johnson <johnson@intel.com>; mesa-dev@lists.freedesktop.org Cc: Lin, Johnson <johnson@intel.com> Subject: Re: [Mesa-dev] [PATCH] fix

Re: [Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

2017-04-28 Thread Kenneth Graunke
On Friday, April 28, 2017 3:02:01 PM PDT Eric Anholt wrote: > Johnson Lin writes: > > > The matrix used for YCbCr to RGB is listed in Wiki > > https://en.wikipedia.org/wiki/YCbCr; > > There is minor error in the matrix constant: 0.0625=16/256 should be > > 16.0/255, > >

Re: [Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

2017-04-28 Thread Eric Anholt
Johnson Lin writes: > The matrix used for YCbCr to RGB is listed in Wiki > https://en.wikipedia.org/wiki/YCbCr; > There is minor error in the matrix constant: 0.0625=16/256 should be 16.0/255, > and 0.5=128.0/256 should be 128.0/255. > Note that conversion from a 0-255

[Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

2017-04-28 Thread Johnson Lin
The matrix used for YCbCr to RGB is listed in Wiki https://en.wikipedia.org/wiki/YCbCr; There is minor error in the matrix constant: 0.0625=16/256 should be 16.0/255, and 0.5=128.0/256 should be 128.0/255. Note that conversion from a 0-255 byte number to 0-1.0 float is to divide by 255 instead