Re: [Mesa-dev] [PATCH] freedreno/ir3: Handle GL_NONE in get_num_components_for_glformat()

2018-12-19 Thread Eduardo Lima Mitev
On 12/19/18 9:23 PM, Ilia Mirkin wrote: > On Wed, Dec 19, 2018 at 3:18 AM Eduardo Lima Mitev wrote: >> >> An earlier patch that introduced the function failed to handle the case >> where an image format layout qualifier is not specified, which is allowed >> in Core profiles. In these cases,

Re: [Mesa-dev] [PATCH] freedreno/ir3: Handle GL_NONE in get_num_components_for_glformat()

2018-12-19 Thread Ilia Mirkin
On Wed, Dec 19, 2018 at 3:18 AM Eduardo Lima Mitev wrote: > > An earlier patch that introduced the function failed to handle the case > where an image format layout qualifier is not specified, which is allowed > in Core profiles. In these cases, nir_variable's image format is > GL_NONE, and we

[Mesa-dev] [PATCH] freedreno/ir3: Handle GL_NONE in get_num_components_for_glformat()

2018-12-19 Thread Eduardo Lima Mitev
An earlier patch that introduced the function failed to handle the case where an image format layout qualifier is not specified, which is allowed in Core profiles. In these cases, nir_variable's image format is GL_NONE, and we don't need to print a debug message for those. ---