Re: [Mesa-dev] [PATCH] gallium/swr: confine c++11 flag to swr driver

2016-04-15 Thread Emil Velikov
On 15 April 2016 at 00:30, Tim Rowley wrote: > --- a/src/gallium/drivers/swr/Makefile.am > +++ b/src/gallium/drivers/swr/Makefile.am > @@ -22,7 +22,7 @@ > include Makefile.sources > include $(top_srcdir)/src/gallium/Automake.inc > > -AM_CXXFLAGS =

Re: [Mesa-dev] [PATCH] gallium/swr: confine c++11 flag to swr driver

2016-04-15 Thread Ilia Mirkin
On Fri, Apr 15, 2016 at 12:10 PM, Chuck Atkins wrote: >> > As LLVM_CXXFLAGS / `llvm-config --cxxflags` already includes std=c++11 >> >> Yes, I saw that and considered going that direction, but wasn’t sure if we >> should rely on llvm setting the language version

Re: [Mesa-dev] [PATCH] gallium/swr: confine c++11 flag to swr driver

2016-04-15 Thread Chuck Atkins
> > > As LLVM_CXXFLAGS / `llvm-config --cxxflags` already includes std=c++11 > > Yes, I saw that and considered going that direction, but wasn’t sure if we > should rely on llvm setting the language version required. > Shouldn't you do both? Use LLVM_CXXFLAGS since swr is C++ code including and

Re: [Mesa-dev] [PATCH] gallium/swr: confine c++11 flag to swr driver

2016-04-15 Thread Rowley, Timothy O
> On Apr 15, 2016, at 10:33 AM, Jose Fonseca wrote: > > On 15/04/16 00:30, Tim Rowley wrote: >> On the philosophy that a driver shouldn't change the compile flags >> for the entire tree, take the clove approach of moving the c++11 flag >> to the swr driver directory. >> ---

Re: [Mesa-dev] [PATCH] gallium/swr: confine c++11 flag to swr driver

2016-04-15 Thread Jose Fonseca
On 15/04/16 00:30, Tim Rowley wrote: On the philosophy that a driver shouldn't change the compile flags for the entire tree, take the clove approach of moving the c++11 flag to the swr driver directory. --- configure.ac| 9 +- m4/ax_cxx_compile_stdcxx.m4 |

[Mesa-dev] [PATCH] gallium/swr: confine c++11 flag to swr driver

2016-04-14 Thread Tim Rowley
On the philosophy that a driver shouldn't change the compile flags for the entire tree, take the clove approach of moving the c++11 flag to the swr driver directory. --- configure.ac| 9 +- m4/ax_cxx_compile_stdcxx.m4 | 558