Re: [Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

2017-04-29 Thread Emil Velikov
On 29 April 2017 at 14:24, Ilia Mirkin wrote: > On Sat, Apr 29, 2017 at 9:18 AM, Emil Velikov > wrote: >> On 18 April 2017 at 05:00, Ilia Mirkin wrote: >>> val_bool and val_int are in a union. val_bool gets the first byte,

Re: [Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

2017-04-29 Thread Ilia Mirkin
On Sat, Apr 29, 2017 at 9:18 AM, Emil Velikov wrote: > On 18 April 2017 at 05:00, Ilia Mirkin wrote: >> val_bool and val_int are in a union. val_bool gets the first byte, which >> happens to work on LE when setting via the int, but breaks on BE. By

Re: [Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

2017-04-29 Thread Emil Velikov
On 18 April 2017 at 05:00, Ilia Mirkin wrote: > val_bool and val_int are in a union. val_bool gets the first byte, which > happens to work on LE when setting via the int, but breaks on BE. By > setting the value properly, we are able to use DRI3 on BE architectures. > Tested

Re: [Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

2017-04-18 Thread Michel Dänzer
On 18/04/17 09:52 PM, Ilia Mirkin wrote: > On Tue, Apr 18, 2017 at 2:21 AM, Michel Dänzer wrote: >> On 18/04/17 01:02 PM, Ilia Mirkin wrote: >>> On Tue, Apr 18, 2017 at 12:00 AM, Ilia Mirkin wrote: val_bool and val_int are in a union. val_bool gets

Re: [Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

2017-04-18 Thread Ilia Mirkin
On Tue, Apr 18, 2017 at 2:21 AM, Michel Dänzer wrote: > On 18/04/17 01:02 PM, Ilia Mirkin wrote: >> On Tue, Apr 18, 2017 at 12:00 AM, Ilia Mirkin wrote: >>> val_bool and val_int are in a union. val_bool gets the first byte, which >>> happens to work on

Re: [Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

2017-04-18 Thread Michel Dänzer
On 18/04/17 01:02 PM, Ilia Mirkin wrote: > On Tue, Apr 18, 2017 at 12:00 AM, Ilia Mirkin wrote: >> val_bool and val_int are in a union. val_bool gets the first byte, which >> happens to work on LE when setting via the int, but breaks on BE. By >> setting the value properly,

Re: [Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

2017-04-17 Thread Edward O'Callaghan
On 04/18/2017 02:02 PM, Ilia Mirkin wrote: > On Tue, Apr 18, 2017 at 12:00 AM, Ilia Mirkin wrote: >> val_bool and val_int are in a union. val_bool gets the first byte, which >> happens to work on LE when setting via the int, but breaks on BE. By >> setting the value

Re: [Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

2017-04-17 Thread Ilia Mirkin
On Tue, Apr 18, 2017 at 12:00 AM, Ilia Mirkin wrote: > val_bool and val_int are in a union. val_bool gets the first byte, which > happens to work on LE when setting via the int, but breaks on BE. By > setting the value properly, we are able to use DRI3 on BE architectures. >

[Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

2017-04-17 Thread Ilia Mirkin
val_bool and val_int are in a union. val_bool gets the first byte, which happens to work on LE when setting via the int, but breaks on BE. By setting the value properly, we are able to use DRI3 on BE architectures. Tested by running glxgears with a NV34 in a G5 PPC. Signed-off-by: Ilia Mirkin