Re: [Mesa-dev] [PATCH] gallium: fix return value check

Thanks. With the int changed to off_t as remarked by others, and the then redundant (off_t) cast in the if-condition removed, this patch is Reviewed-by: Nicolai Hähnle On 07.09.2016 16:34, Martina Kollarova wrote: A possible error (-1) was being lost because it was

Re: [Mesa-dev] [PATCH] gallium: fix return value check

On Wed, 2016-09-07 at 17:34 +0300, Martina Kollarova wrote: > A possible error (-1) was being lost because it was first converted > to an > unsigned int and only then checked. > --- >  src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c | 12 ++-- >  1 file changed, 6 insertions(+), 6

Re: [Mesa-dev] [PATCH] gallium: fix return value check

On Wed, Sep 7, 2016 at 10:34 AM, Martina Kollarova wrote: > A possible error (-1) was being lost because it was first converted to an > unsigned int and only then checked. > --- > src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c | 12 ++-- > 1 file changed,

[Mesa-dev] [PATCH] gallium: fix return value check

A possible error (-1) was being lost because it was first converted to an unsigned int and only then checked. --- src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c