Re: [Mesa-dev] [PATCH] gen7: Use logical, not physical, dims in 3DSTATE_DEPTH_BUFFER (v2)

2013-10-03 Thread Jordan Justen
It would be good to test HSW too. Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On Wed, 2013-10-02 at 17:50 -0700, Chad Versace wrote: In 3DSTATE_DEPTH_BUFFER, we set Width and Height to the miptree slice's physical dimensions. (Logical and physical dimensions may differ for

Re: [Mesa-dev] [PATCH] gen7: Use logical, not physical, dims in 3DSTATE_DEPTH_BUFFER

2013-10-02 Thread Eric Anholt
Chad Versace chad.vers...@linux.intel.com writes: In 3DSTATE_DEPTH_BUFFER, we set Width and Height to the miptree slice's physical dimensions. (Logical and physical dimensions may differ for multisample surfaces). However, in SURFACE_STATE, we always set Width and Height to the slice's

Re: [Mesa-dev] [PATCH] gen7: Use logical, not physical, dims in 3DSTATE_DEPTH_BUFFER

2013-10-02 Thread Jordan Justen
On Wed, Oct 2, 2013 at 10:48 AM, Eric Anholt e...@anholt.net wrote: Chad Versace chad.vers...@linux.intel.com writes: In 3DSTATE_DEPTH_BUFFER, we set Width and Height to the miptree slice's physical dimensions. (Logical and physical dimensions may differ for multisample surfaces). However,

Re: [Mesa-dev] [PATCH] gen7: Use logical, not physical, dims in 3DSTATE_DEPTH_BUFFER

2013-10-02 Thread Ben Widawsky
On Wed, Oct 02, 2013 at 12:41:16PM -0700, Jordan Justen wrote: On Wed, Oct 2, 2013 at 10:48 AM, Eric Anholt e...@anholt.net wrote: Chad Versace chad.vers...@linux.intel.com writes: In 3DSTATE_DEPTH_BUFFER, we set Width and Height to the miptree slice's physical dimensions. (Logical and

Re: [Mesa-dev] [PATCH] gen7: Use logical, not physical, dims in 3DSTATE_DEPTH_BUFFER

2013-10-02 Thread Chad Versace
On 10/02/2013 10:48 AM, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: In 3DSTATE_DEPTH_BUFFER, we set Width and Height to the miptree slice's physical dimensions. (Logical and physical dimensions may differ for multisample surfaces). However, in SURFACE_STATE, we always

[Mesa-dev] [PATCH] gen7: Use logical, not physical, dims in 3DSTATE_DEPTH_BUFFER (v2)

2013-10-02 Thread Chad Versace
In 3DSTATE_DEPTH_BUFFER, we set Width and Height to the miptree slice's physical dimensions. (Logical and physical dimensions may differ for multisample surfaces). However, in SURFACE_STATE, we always set Width and Height to the slice's logical dimensions. We should do the same for

[Mesa-dev] [PATCH] gen7: Use logical, not physical, dims in 3DSTATE_DEPTH_BUFFER

2013-10-01 Thread Chad Versace
In 3DSTATE_DEPTH_BUFFER, we set Width and Height to the miptree slice's physical dimensions. (Logical and physical dimensions may differ for multisample surfaces). However, in SURFACE_STATE, we always set Width and Height to the slice's logical dimensions. We should do the same for

Re: [Mesa-dev] [PATCH] gen7: Use logical, not physical, dims in 3DSTATE_DEPTH_BUFFER

2013-10-01 Thread Ben Widawsky
On Tue, Oct 01, 2013 at 02:43:50PM -0700, Chad Versace wrote: In 3DSTATE_DEPTH_BUFFER, we set Width and Height to the miptree slice's physical dimensions. (Logical and physical dimensions may differ for multisample surfaces). However, in SURFACE_STATE, we always set Width and Height to the