Re: [Mesa-dev] [PATCH] glsl/linker: produce error when invalid explicit locations are used

2017-10-18 Thread Iago Toral
Thanks for the review Nicolai! However, I sent a v2 yesterday that handles some cases better: https://lists.freedesktop.org/archives/mesa-dev/2017-October/173062.htm l Specifically, this v2 computes the location slot for patch variables correctly and fixes a couple of regressions in piglit that

Re: [Mesa-dev] [PATCH] glsl/linker: produce error when invalid explicit locations are used

2017-10-17 Thread Nicolai Hähnle
On 16.10.2017 14:06, Iago Toral Quiroga wrote: We only need to add a check to validate output locations here. For inputs with invalid locations we will fail to link when we can't find a matching output in the same (invalid) location. Fixes: KHR-GL45.enhanced_layouts.varying_location_limit

[Mesa-dev] [PATCH] glsl/linker: produce error when invalid explicit locations are used

2017-10-16 Thread Iago Toral Quiroga
We only need to add a check to validate output locations here. For inputs with invalid locations we will fail to link when we can't find a matching output in the same (invalid) location. Fixes: KHR-GL45.enhanced_layouts.varying_location_limit --- src/compiler/glsl/link_varyings.cpp | 12