Re: [Mesa-dev] [PATCH] glsl: Relax GLSL 1.10 float suffix error to a warning.

2016-04-20 Thread Ian Romanick
On 04/20/2016 07:03 PM, Ian Romanick wrote: > On 04/20/2016 12:29 PM, Matt Turner wrote: >> Float suffixes are allowed in all subsequent GLSL specifications, and >> it's obvious what the user meant if they specify one. Accept it with a >> warning to avoid breaking applications, like Planeshift. >

Re: [Mesa-dev] [PATCH] glsl: Relax GLSL 1.10 float suffix error to a warning.

2016-04-20 Thread Ian Romanick
On 04/20/2016 12:29 PM, Matt Turner wrote: > Float suffixes are allowed in all subsequent GLSL specifications, and > it's obvious what the user meant if they specify one. Accept it with a > warning to avoid breaking applications, like Planeshift. Did we ever figure out if Planeshift still uses F

Re: [Mesa-dev] [PATCH] glsl: Relax GLSL 1.10 float suffix error to a warning.

2016-04-20 Thread Kenneth Graunke
On Wednesday, April 20, 2016 12:29:23 PM PDT Matt Turner wrote: > Float suffixes are allowed in all subsequent GLSL specifications, and > it's obvious what the user meant if they specify one. Accept it with a > warning to avoid breaking applications, like Planeshift. > --- >

Re: [Mesa-dev] [PATCH] glsl: Relax GLSL 1.10 float suffix error to a warning.

2016-04-20 Thread Matt Turner
On Wed, Apr 20, 2016 at 12:48 PM, Lars Hamre wrote: > I am fine with this, it would be nice if we could modify the following > piglit tests to pass when a warning is emitted: >

Re: [Mesa-dev] [PATCH] glsl: Relax GLSL 1.10 float suffix error to a warning.

2016-04-20 Thread Roland Scheidegger
Am 20.04.2016 um 21:29 schrieb Matt Turner: > Float suffixes are allowed in all subsequent GLSL specifications, and > it's obvious what the user meant if they specify one. Accept it with a > warning to avoid breaking applications, like Planeshift. > --- > src/compiler/glsl/glsl_lexer.ll | 4 ++--

Re: [Mesa-dev] [PATCH] glsl: Relax GLSL 1.10 float suffix error to a warning.

2016-04-20 Thread Lars Hamre
I am fine with this, it would be nice if we could modify the following piglit tests to pass when a warning is emitted: https://cgit.freedesktop.org/piglit/tree/tests/spec/glsl-1.10/compiler/literals/invalid-float-suffix-capital-f.vert

[Mesa-dev] [PATCH] glsl: Relax GLSL 1.10 float suffix error to a warning.

2016-04-20 Thread Matt Turner
Float suffixes are allowed in all subsequent GLSL specifications, and it's obvious what the user meant if they specify one. Accept it with a warning to avoid breaking applications, like Planeshift. --- src/compiler/glsl/glsl_lexer.ll | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff