Re: [Mesa-dev] [PATCH] glsl: buffer variables can be readonly and writeonly

2017-09-18 Thread Juan A. Suarez Romero
On Mon, 2017-09-18 at 10:50 +0200, Samuel Pitoiset wrote: > > On 09/15/2017 04:56 PM, Juan A. Suarez Romero wrote: > > On Fri, 2017-09-15 at 13:04 +0200, Juan A. Suarez Romero wrote: > > > On Fri, 2017-09-15 at 12:47 +0200, Samuel Pitoiset wrote: > > > > I guess this will break some piglits. > >

Re: [Mesa-dev] [PATCH] glsl: buffer variables can be readonly and writeonly

2017-09-18 Thread Samuel Pitoiset
On 09/15/2017 04:56 PM, Juan A. Suarez Romero wrote: On Fri, 2017-09-15 at 13:04 +0200, Juan A. Suarez Romero wrote: On Fri, 2017-09-15 at 12:47 +0200, Samuel Pitoiset wrote: I guess this will break some piglits. Right. I'll check them and provide fixes After running piglit with and

Re: [Mesa-dev] [PATCH] glsl: buffer variables can be readonly and writeonly

2017-09-15 Thread Juan A. Suarez Romero
On Fri, 2017-09-15 at 13:04 +0200, Juan A. Suarez Romero wrote: > On Fri, 2017-09-15 at 12:47 +0200, Samuel Pitoiset wrote: > > I guess this will break some piglits. > > > > > Right. I'll check them and provide fixes After running piglit with and without this patch, I didn't find any

Re: [Mesa-dev] [PATCH] glsl: buffer variables can be readonly and writeonly

2017-09-15 Thread Juan A. Suarez Romero
On Fri, 2017-09-15 at 12:47 +0200, Samuel Pitoiset wrote: > I guess this will break some piglits. > Right. I'll check them and provide fixes Thanks. J.A. > On 09/15/2017 10:49 AM, Juan A. Suarez Romero wrote: > > In GLSL ES 3.10 session 4.9 [Memory Access Qualifiers], it has the >

Re: [Mesa-dev] [PATCH] glsl: buffer variables can be readonly and writeonly

2017-09-15 Thread Samuel Pitoiset
I guess this will break some piglits. On 09/15/2017 10:49 AM, Juan A. Suarez Romero wrote: In GLSL ES 3.10 session 4.9 [Memory Access Qualifiers], it has the following description: "A variable could be qualified as both readonly and writeonly, disallowing both read and write, but still be

[Mesa-dev] [PATCH] glsl: buffer variables can be readonly and writeonly

2017-09-15 Thread Juan A. Suarez Romero
In GLSL ES 3.10 session 4.9 [Memory Access Qualifiers], it has the following description: "A variable could be qualified as both readonly and writeonly, disallowing both read and write, but still be passed to imageSize() to have the size queried.". This is for image variable, but not for