Re: [Mesa-dev] [PATCH] i965/blorp: Fix clear rectangle alignment in fast color clear

2013-07-10 Thread Anuj Phogat
On Tue, Jul 9, 2013 at 6:44 PM, Chris Forbes chr...@ijw.co.nz wrote: I think it would be clearer to do this, rather than 4 parallel checks: Yes. It's clearer. I will make this change. if (intel-gen = 7) { /* rationale ... */ x0 = ROUND_DOWN_TO(x0, 2 * x_align); y0 =

Re: [Mesa-dev] [PATCH] i965/blorp: Fix clear rectangle alignment in fast color clear

2013-07-10 Thread Paul Berry
On 9 July 2013 18:12, Anuj Phogat anuj.pho...@gmail.com wrote: For HSW GT3 clear rectangle must be aligned to two times the number of pixels in the table shown in Ivy Bridge PRM, Vol2 Part1 11.7. It should be safe to do this for all gen7 systems unless we see any performance regressions. I

Re: [Mesa-dev] [PATCH] i965/blorp: Fix clear rectangle alignment in fast color clear

2013-07-10 Thread Kenneth Graunke
On 07/10/2013 11:09 AM, Paul Berry wrote: On 9 July 2013 18:12, Anuj Phogat anuj.pho...@gmail.com mailto:anuj.pho...@gmail.com wrote: For HSW GT3 clear rectangle must be aligned to two times the number of pixels in the table shown in Ivy Bridge PRM, Vol2 Part1 11.7. It should be

Re: [Mesa-dev] [PATCH] i965/blorp: Fix clear rectangle alignment in fast color clear

2013-07-10 Thread Ian Romanick
On 07/09/2013 06:12 PM, Anuj Phogat wrote: For HSW GT3 clear rectangle must be aligned to two times the number of pixels in the table shown in Ivy Bridge PRM, Vol2 Part1 11.7. It should be safe to do this for all gen7 systems unless we see any performance regressions. I observed no piglit,

Re: [Mesa-dev] [PATCH] i965/blorp: Fix clear rectangle alignment in fast color clear

2013-07-09 Thread Chris Forbes
I think it would be clearer to do this, rather than 4 parallel checks: if (intel-gen = 7) { /* rationale ... */ x0 = ROUND_DOWN_TO(x0, 2 * x_align); y0 = ROUND_DOWN_TO(y0, 2 * y_align); x1 = ALIGN(x1, 2 * x_align); y1 = ALIGN(y1, 2 * y_align); } else { x0 =