Re: [Mesa-dev] [PATCH] i965: Momentarily pretend to support ARB_texture_stencil8 for blits.

2015-06-10 Thread Kenneth Graunke
On Wednesday, June 10, 2015 08:48:21 AM Martin Peres wrote: On 10/06/2015 01:18, Kenneth Graunke wrote: Broadwell's stencil blitting code attempts to bind a renderbuffer as a texture, using dd-BindRenderbufferTexImage(). This calls _mesa_init_teximage_fields(), which then attempts to set

Re: [Mesa-dev] [PATCH] i965: Momentarily pretend to support ARB_texture_stencil8 for blits.

2015-06-10 Thread Neil Roberts
Kenneth Graunke kenn...@whitecape.org writes: _mesa_meta_fb_tex_blit_begin(ctx, blit); + ctx-Extensions.ARB_texture_stencil8 = true; Maybe you could put assert(ctx-Extensions.ARB_texture_stencil8==false) just before setting it to true so that we'll definitely remember to remove it if we

Re: [Mesa-dev] [PATCH] i965: Momentarily pretend to support ARB_texture_stencil8 for blits.

2015-06-10 Thread Jason Ekstrand
On Jun 10, 2015 9:57 AM, Neil Roberts n...@linux.intel.com wrote: Kenneth Graunke kenn...@whitecape.org writes: _mesa_meta_fb_tex_blit_begin(ctx, blit); + ctx-Extensions.ARB_texture_stencil8 = true; Maybe you could put assert(ctx-Extensions.ARB_texture_stencil8==false) just before

Re: [Mesa-dev] [PATCH] i965: Momentarily pretend to support ARB_texture_stencil8 for blits.

2015-06-10 Thread Kenneth Graunke
On Wednesday, June 10, 2015 05:57:05 PM Neil Roberts wrote: Kenneth Graunke kenn...@whitecape.org writes: _mesa_meta_fb_tex_blit_begin(ctx, blit); + ctx-Extensions.ARB_texture_stencil8 = true; Maybe you could put assert(ctx-Extensions.ARB_texture_stencil8==false) just before

[Mesa-dev] [PATCH] i965: Momentarily pretend to support ARB_texture_stencil8 for blits.

2015-06-09 Thread Kenneth Graunke
Broadwell's stencil blitting code attempts to bind a renderbuffer as a texture, using dd-BindRenderbufferTexImage(). This calls _mesa_init_teximage_fields(), which then attempts to set img-_BaseFormat = _mesa_base_tex_format(ctx, internalFormat), which assert fails if internalFormat is

Re: [Mesa-dev] [PATCH] i965: Momentarily pretend to support ARB_texture_stencil8 for blits.

2015-06-09 Thread Martin Peres
On 10/06/2015 01:18, Kenneth Graunke wrote: Broadwell's stencil blitting code attempts to bind a renderbuffer as a texture, using dd-BindRenderbufferTexImage(). This calls _mesa_init_teximage_fields(), which then attempts to set img-_BaseFormat = _mesa_base_tex_format(ctx, internalFormat),