Re: [Mesa-dev] [PATCH] i965: don't check ccs_e support if isl_format is ISL_FORMAT_UNSUPPORTED

2018-07-06 Thread Dongwon Kim
Hi Lionel, The original problem we saw happened when dri format is __DRI_IMAGE_FORMAT_XBGR2101010, which doesn't have any corresponding ISL format available. And yes, I verified the problem we saw doesn't happen anymore with the latest code base possibly with your fix. So I could turn down this

Re: [Mesa-dev] [PATCH] i965: don't check ccs_e support if isl_format is ISL_FORMAT_UNSUPPORTED

2018-07-06 Thread Lionel Landwerlin
Hi Dongwon, Jason & I merged some patches to fix similar issues a few weeks ago. I think we didn't change this function because a crash or hitting an assert is a good indication that something's gone wrong before we run into this function. If you patch fixes an issue, could you give some

[Mesa-dev] [PATCH] i965: don't check ccs_e support if isl_format is ISL_FORMAT_UNSUPPORTED

2018-07-05 Thread Dongwon Kim
'ISL_FORMAT_UNSUPPORTED' shouldn't be passed down for evaluation as it is strictly prohibited in isl code (e.g. format_info_exists). Signed-off-by: Dongwon Kim --- src/mesa/drivers/dri/i965/intel_screen.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git