Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-29 Thread Jason Ekstrand
Julien, Mind if I ask what your use-case is? We've been talking about trying to remove tiled mapping from the driver and using blits instead. I don't want to suddenly drop someone off a performance cliff. Thanks, --Jason On Tue, Nov 14, 2017 at 3:05 AM, Julien Isorce

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-14 Thread Chris Wilson
Quoting Julien Isorce (2017-11-14 11:05:52) > Already implemented for Gallium drivers. > > Useful for gbm_bo_(un)map. > > Tests: > By porting wayland/weston/clients/simple-dmabuf-drm.c to GBM. > kmscube --mode=rgba > kmscube --mode=nv12-1img > kmscube --mode=nv12-2img > piglit

[Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-14 Thread Julien Isorce
Already implemented for Gallium drivers. Useful for gbm_bo_(un)map. Tests: By porting wayland/weston/clients/simple-dmabuf-drm.c to GBM. kmscube --mode=rgba kmscube --mode=nv12-1img kmscube --mode=nv12-2img piglit ext_image_dma_buf_import-refcount -auto piglit

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-14 Thread Chris Wilson
Quoting Julien Isorce (2017-11-09 17:03:13) > v2: add early return if (flag & MAP_INTERNAL_MASK) > v3: take input rect into account and test with kmscube and piglit. > v4: handle wraparound and bo reference. > > Already implemented for Gallium drivers. > > Useful for gbm_bo_(un)map. > > Tests:

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-14 Thread Julien Isorce
Thx for pointing that. Gentle ping, anyone wants to mark 'reviewed' this patch ? On 10 November 2017 at 16:18, Rafael Antognolli wrote: > On Fri, Nov 10, 2017 at 10:46:03AM +, Julien Isorce wrote: > > Thx for the suggestions. > > > > Anyone familiar with

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-10 Thread Rafael Antognolli
On Fri, Nov 10, 2017 at 10:46:03AM +, Julien Isorce wrote: > Thx for the suggestions. > > Anyone familiar with _mesa_get_format_block_size and _mesa_get_format_bytes > wants to review this patch ? > > On 9 November 2017 at 17:10, Eric Engestrom wrote: > > On

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-10 Thread Julien Isorce
Thx for the suggestions. Anyone familiar with _mesa_get_format_block_size and _mesa_get_format_bytes wants to review this patch ? On 9 November 2017 at 17:10, Eric Engestrom wrote: > On Thursday, 2017-11-09 17:03:13 +, Julien Isorce wrote: > > v2: add early

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-09 Thread Eric Engestrom
On Thursday, 2017-11-09 17:03:13 +, Julien Isorce wrote: > v2: add early return if (flag & MAP_INTERNAL_MASK) > v3: take input rect into account and test with kmscube and piglit. > v4: handle wraparound and bo reference. > > Already implemented for Gallium drivers. > > Useful for

[Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-09 Thread Julien Isorce
v2: add early return if (flag & MAP_INTERNAL_MASK) v3: take input rect into account and test with kmscube and piglit. v4: handle wraparound and bo reference. Already implemented for Gallium drivers. Useful for gbm_bo_(un)map. Tests: By porting wayland/weston/clients/simple-dmabuf-drm.c to

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-09 Thread Julien Isorce
Hi Emil, Thx for the suggestion about kmscube and piglit. I tried them and I have sent a v3 patch. Hi Chris, I can see that in Ben's patch it calls brw_bo_unreference instead of brw_bo_unmap. Also the existing brw_bo_unmap is a no op (strange it is implemented as just return 0) Any idea ? Thx

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-09 Thread Chris Wilson
Quoting Julien Isorce (2017-11-09 15:30:23) > v2: add early return if (flag & MAP_INTERNAL_MASK) > v3: take input rect into account and test with kmscube and piglit. > > Already implemented for Gallium drivers. > > Useful for gbm_bo_(un)map. > > Tests: > By porting

[Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-09 Thread Julien Isorce
v2: add early return if (flag & MAP_INTERNAL_MASK) v3: take input rect into account and test with kmscube and piglit. Already implemented for Gallium drivers. Useful for gbm_bo_(un)map. Tests: By porting wayland/weston/clients/simple-dmabuf-drm.c to GBM. kmscube --mode=rgba kmscube

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-08 Thread Julien Isorce
Ah yes you are right, my mistake. I will update the patch after some more testing. Thx. On 8 November 2017 at 17:21, Chris Wilson wrote: > Quoting Julien Isorce (2017-11-08 16:55:05) > > v2: add early return if (flag & MAP_INTERNAL_MASK) > > > > Already implemented for

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-08 Thread Chris Wilson
Quoting Julien Isorce (2017-11-08 16:55:05) > v2: add early return if (flag & MAP_INTERNAL_MASK) > > Already implemented for Gallium drivers. > > Useful for gbm_bo_(un)map. > > Tested by porting wayland/weston/clients/simple-dmabuf-drm.c to GBM. > > Signed-off-by: Julien Isorce

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-08 Thread Emil Velikov
Hi Julien, On 8 November 2017 at 16:55, Julien Isorce wrote: > v2: add early return if (flag & MAP_INTERNAL_MASK) > > Already implemented for Gallium drivers. > > Useful for gbm_bo_(un)map. > > Tested by porting wayland/weston/clients/simple-dmabuf-drm.c to GBM. > Ben

[Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-08 Thread Julien Isorce
v2: add early return if (flag & MAP_INTERNAL_MASK) Already implemented for Gallium drivers. Useful for gbm_bo_(un)map. Tested by porting wayland/weston/clients/simple-dmabuf-drm.c to GBM. Signed-off-by: Julien Isorce --- src/mesa/drivers/dri/i965/intel_screen.c | 51

[Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-06 Thread Julien Isorce
Already implemented for Gallium drivers. Useful for gbm_bo_(un)map. Tested by porting wayland/weston/clients/simple-dmabuf-drm.c to GBM. Signed-off-by: Julien Isorce --- src/mesa/drivers/dri/i965/intel_screen.c | 47 ++-- 1 file changed, 45