Re: [Mesa-dev] [PATCH] i965: make sure check_and_emit_atom gets inlined

[Scott D Phillips]

Tapani Pälli  writes:
> Improves performance of 3DMark "Ice Storm Unlimited" benchmark
> by 1-2% on Apollolake (on Android-IA using clang 3.8.256229).
>
> Change is based on the performance profiling work and results
> by Aravindan Muthukumar and Yogesh Marathe.
>
> Signed-off-by: Tapani Pälli 

Ya, this makes more sense to me. Given Yogesh is happy with his
benchmark too then this is
Reviewed-by: Scott D Phillips 

> ---
>  src/mesa/drivers/dri/i965/brw_state_upload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c 
> b/src/mesa/drivers/dri/i965/brw_state_upload.c
> index f38c1946df..1ae45ba2ac 100644
> --- a/src/mesa/drivers/dri/i965/brw_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/brw_state_upload.c
> @@ -447,7 +447,7 @@ merge_ctx_state(struct brw_context *brw,
> state->brw |= brw->ctx.NewDriverState;
>  }
>  
> -static inline void
> +static ALWAYS_INLINE void
>  check_and_emit_atom(struct brw_context *brw,
>  struct brw_state_flags *state,
>  const struct brw_tracked_state *atom)
> -- 
> 2.13.5
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: make sure check_and_emit_atom gets inlined

[Tapani Pälli]

Improves performance of 3DMark "Ice Storm Unlimited" benchmark
by 1-2% on Apollolake (on Android-IA using clang 3.8.256229).

Change is based on the performance profiling work and results
by Aravindan Muthukumar and Yogesh Marathe.

Signed-off-by: Tapani Pälli 
---
 src/mesa/drivers/dri/i965/brw_state_upload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c 
b/src/mesa/drivers/dri/i965/brw_state_upload.c
index f38c1946df..1ae45ba2ac 100644
--- a/src/mesa/drivers/dri/i965/brw_state_upload.c
+++ b/src/mesa/drivers/dri/i965/brw_state_upload.c
@@ -447,7 +447,7 @@ merge_ctx_state(struct brw_context *brw,
state->brw |= brw->ctx.NewDriverState;
 }
 
-static inline void
+static ALWAYS_INLINE void
 check_and_emit_atom(struct brw_context *brw,
 struct brw_state_flags *state,
 const struct brw_tracked_state *atom)
-- 
2.13.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev