Re: [Mesa-dev] [PATCH] i965: remove unused brw_nir_lower_cs_shared()

[Elie Tournier]

On Mon, Feb 05, 2018 at 09:22:15AM +1100, Timothy Arceri wrote:
> This has been unused since 8761a04d0d93.

Reviewed-by: Elie Tournier 
> ---
>  src/intel/compiler/brw_nir.c | 8 
>  src/intel/compiler/brw_nir.h | 1 -
>  2 files changed, 9 deletions(-)
> 
> diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c
> index dbddef0d04..405985f8b6 100644
> --- a/src/intel/compiler/brw_nir.c
> +++ b/src/intel/compiler/brw_nir.c
> @@ -503,14 +503,6 @@ brw_nir_lower_fs_outputs(nir_shader *nir)
> nir_lower_io(nir, nir_var_shader_out, type_size_dvec4, 0);
>  }
>  
> -void
> -brw_nir_lower_cs_shared(nir_shader *nir)
> -{
> -   nir_assign_var_locations(>shared, >num_shared,
> -type_size_scalar_bytes);
> -   nir_lower_io(nir, nir_var_shared, type_size_scalar_bytes, 0);
> -}
> -
>  #define OPT(pass, ...) ({  \
> bool this_progress = false; \
> NIR_PASS(this_progress, nir, pass, ##__VA_ARGS__);  \
> diff --git a/src/intel/compiler/brw_nir.h b/src/intel/compiler/brw_nir.h
> index 3bef99417e..03f52da08e 100644
> --- a/src/intel/compiler/brw_nir.h
> +++ b/src/intel/compiler/brw_nir.h
> @@ -113,7 +113,6 @@ void brw_nir_lower_vue_outputs(nir_shader *nir, bool 
> is_scalar);
>  void brw_nir_lower_tcs_outputs(nir_shader *nir, const struct brw_vue_map 
> *vue,
> GLenum tes_primitive_mode);
>  void brw_nir_lower_fs_outputs(nir_shader *nir);
> -void brw_nir_lower_cs_shared(nir_shader *nir);
>  
>  nir_shader *brw_postprocess_nir(nir_shader *nir,
>  const struct brw_compiler *compiler,
> -- 
> 2.14.3
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: remove unused brw_nir_lower_cs_shared()

[Timothy Arceri]

This has been unused since 8761a04d0d93.
---
 src/intel/compiler/brw_nir.c | 8 
 src/intel/compiler/brw_nir.h | 1 -
 2 files changed, 9 deletions(-)

diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c
index dbddef0d04..405985f8b6 100644
--- a/src/intel/compiler/brw_nir.c
+++ b/src/intel/compiler/brw_nir.c
@@ -503,14 +503,6 @@ brw_nir_lower_fs_outputs(nir_shader *nir)
nir_lower_io(nir, nir_var_shader_out, type_size_dvec4, 0);
 }
 
-void
-brw_nir_lower_cs_shared(nir_shader *nir)
-{
-   nir_assign_var_locations(>shared, >num_shared,
-type_size_scalar_bytes);
-   nir_lower_io(nir, nir_var_shared, type_size_scalar_bytes, 0);
-}
-
 #define OPT(pass, ...) ({  \
bool this_progress = false; \
NIR_PASS(this_progress, nir, pass, ##__VA_ARGS__);  \
diff --git a/src/intel/compiler/brw_nir.h b/src/intel/compiler/brw_nir.h
index 3bef99417e..03f52da08e 100644
--- a/src/intel/compiler/brw_nir.h
+++ b/src/intel/compiler/brw_nir.h
@@ -113,7 +113,6 @@ void brw_nir_lower_vue_outputs(nir_shader *nir, bool 
is_scalar);
 void brw_nir_lower_tcs_outputs(nir_shader *nir, const struct brw_vue_map *vue,
GLenum tes_primitive_mode);
 void brw_nir_lower_fs_outputs(nir_shader *nir);
-void brw_nir_lower_cs_shared(nir_shader *nir);
 
 nir_shader *brw_postprocess_nir(nir_shader *nir,
 const struct brw_compiler *compiler,
-- 
2.14.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev