Re: [Mesa-dev] [PATCH] i965: vs optimization fix: Check val.negate in accumulator_contains()

2011-07-24 Thread Eric Anholt
On Sat, 23 Jul 2011 09:38:05 -0700, Paul Berry stereotype...@gmail.com wrote: On 22 July 2011 18:17, Eric Anholt e...@anholt.net wrote: On Fri, 22 Jul 2011 15:07:57 -0700, Paul Berry stereotype...@gmail.com wrote: When emitting a MAC instruction in a vertex shader, brw_vs_emit() calls

Re: [Mesa-dev] [PATCH] i965: vs optimization fix: Check val.negate in accumulator_contains()

2011-07-23 Thread Paul Berry
On 22 July 2011 18:17, Eric Anholt e...@anholt.net wrote: On Fri, 22 Jul 2011 15:07:57 -0700, Paul Berry stereotype...@gmail.com wrote: When emitting a MAC instruction in a vertex shader, brw_vs_emit() calls accumulator_contains() to determine whether the accumulator already contains the

[Mesa-dev] [PATCH] i965: vs optimization fix: Check val.negate in accumulator_contains()

2011-07-22 Thread Paul Berry
When emitting a MAC instruction in a vertex shader, brw_vs_emit() calls accumulator_contains() to determine whether the accumulator already contains the appropriate addend; if it does, then we can avoid emitting an unnecessary MOV instruction. However, accumulator_contains() wasn't checking the

Re: [Mesa-dev] [PATCH] i965: vs optimization fix: Check val.negate in accumulator_contains()

2011-07-22 Thread Eric Anholt
On Fri, 22 Jul 2011 15:07:57 -0700, Paul Berry stereotype...@gmail.com wrote: When emitting a MAC instruction in a vertex shader, brw_vs_emit() calls accumulator_contains() to determine whether the accumulator already contains the appropriate addend; if it does, then we can avoid emitting an