Re: [Mesa-dev] [PATCH] intel/compiler: Set swizzle to BRW_SWIZZLE_XXXX for scalar region

2018-12-10 Thread Matt Turner
On Sat, Dec 8, 2018 at 9:51 PM Sagar Ghuge wrote: > > When RepCtrl is set, the swizzle field is ignored by the hardware. In > order to ensure a 1-to-1 correspondence between the human-readable > disassembly and the binary instruction encoding always set the swizzle > to (all zeros) when it

[Mesa-dev] [PATCH] intel/compiler: Set swizzle to BRW_SWIZZLE_XXXX for scalar region

2018-12-08 Thread Sagar Ghuge
When RepCtrl is set, the swizzle field is ignored by the hardware. In order to ensure a 1-to-1 correspondence between the human-readable disassembly and the binary instruction encoding always set the swizzle to (all zeros) when it is unused due to RepCtrl Signed-off-by: Sagar Ghuge

[Mesa-dev] [PATCH] intel/compiler: Set swizzle to BRW_SWIZZLE_XXXX for scalar region

2018-10-24 Thread Sagar Ghuge
For 3 source operand instruction with access mode align16, channel select does not apply when RepCtrl is enabled, So setting it to BRW_SWIZZLE_ seems more appropriate choice. Signed-off-by: Sagar Ghuge --- src/intel/compiler/brw_eu_emit.c | 19 ++- 1 file changed, 18