Re: [Mesa-dev] [PATCH] intel/compiler: emit actual barriers for working-group level barriers

2018-07-09 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Jul 9, 2018 at 2:09 AM Iago Toral wrote: > Any feedback about this? We need this to fix some new CTS tests. > > On Thu, 2018-06-21 at 13:52 +0200, Iago Toral Quiroga wrote: > > Until now we have assumed that we could skip emitting these barriers > > in the

Re: [Mesa-dev] [PATCH] intel/compiler: emit actual barriers for working-group level barriers

2018-07-09 Thread Iago Toral
Any feedback about this? We need this to fix some new CTS tests. On Thu, 2018-06-21 at 13:52 +0200, Iago Toral Quiroga wrote: > Until now we have assumed that we could skip emitting these barriers > in the general case based on empirical testing and a few assumptions > detailed in a comment in

[Mesa-dev] [PATCH] intel/compiler: emit actual barriers for working-group level barriers

2018-06-21 Thread Iago Toral Quiroga
Until now we have assumed that we could skip emitting these barriers in the general case based on empirical testing and a few assumptions detailed in a comment in the driver code, however, recent CTS tests have showed that we actually need them to produce correct behavior. ---