Re: [Mesa-dev] [PATCH] intel/eu/validate: Look up types on demand in execution_type()

2017-09-13 Thread Emil Velikov
On 13 September 2017 at 21:35, Matt Turner wrote: > On 09/13, Emil Velikov wrote: >> >> As Andres pointed out this commit depends on 4fab67a4415 et al, which >> seems to be missing in 17.1 and 17.2. >> >> I've ported this to 17.2 by moving the brw_inst_src[01]_reg_type() >>

Re: [Mesa-dev] [PATCH] intel/eu/validate: Look up types on demand in execution_type()

2017-09-13 Thread Matt Turner
On 09/13, Emil Velikov wrote: As Andres pointed out this commit depends on 4fab67a4415 et al, which seems to be missing in 17.1 and 17.2. I've ported this to 17.2 by moving the brw_inst_src[01]_reg_type() calls as in the original patch. The brw_inst_src[01]_reg_file() ones are left as-is.

Re: [Mesa-dev] [PATCH] intel/eu/validate: Look up types on demand in execution_type()

2017-09-13 Thread Emil Velikov
Hi all, On 31 August 2017 at 23:48, Jason Ekstrand wrote: > We are looking up the execution type prior to checking how many sources > we have. This leads to looking for a type for src1 on MOV instructions > which is bogus. On BDW+, the src1 register type overlaps with the

Re: [Mesa-dev] [PATCH] intel/eu/validate: Look up types on demand in execution_type()

2017-09-13 Thread Matt Turner
On Wed, Sep 13, 2017 at 6:03 AM, Andres Gomez wrote: > Jason, this patch landed tagged for mesa-stable but without mentioning > any specific branch. > > For 17.1 it depends on earlier commit 4fab67a4415 which did not land in > the branch so I'm keeping it out. > > I hope this

Re: [Mesa-dev] [PATCH] intel/eu/validate: Look up types on demand in execution_type()

2017-09-13 Thread Andres Gomez
Jason, this patch landed tagged for mesa-stable but without mentioning any specific branch. For 17.1 it depends on earlier commit 4fab67a4415 which did not land in the branch so I'm keeping it out. I hope this is OK with you. On Thu, 2017-08-31 at 15:48 -0700, Jason Ekstrand wrote: > We are

Re: [Mesa-dev] [PATCH] intel/eu/validate: Look up types on demand in execution_type()

2017-08-31 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] intel/eu/validate: Look up types on demand in execution_type()

2017-08-31 Thread Jason Ekstrand
We are looking up the execution type prior to checking how many sources we have. This leads to looking for a type for src1 on MOV instructions which is bogus. On BDW+, the src1 register type overlaps with the 64-bit immediate and causes us problems. --- src/intel/compiler/brw_eu_validate.c | 6