Re: [Mesa-dev] [PATCH] intel/fs: Bail in optimize_extract_to_float if we have modifiers

2019-02-14 Thread Jason Ekstrand
On Thu, Feb 14, 2019 at 1:18 PM Matt Turner wrote: > On Mon, Feb 11, 2019 at 8:44 PM Jason Ekstrand > wrote: > > > > This fixes a bug in runscape where we were optimizing x >> 16 to an > > extract and then negating and converting to float. The NIR to fs pass > > was dropping the negate on the

Re: [Mesa-dev] [PATCH] intel/fs: Bail in optimize_extract_to_float if we have modifiers

2019-02-14 Thread Matt Turner
On Mon, Feb 11, 2019 at 8:44 PM Jason Ekstrand wrote: > > This fixes a bug in runscape where we were optimizing x >> 16 to an > extract and then negating and converting to float. The NIR to fs pass > was dropping the negate on the floor breaking a geometry shader and > causing it to render

Re: [Mesa-dev] [PATCH] intel/fs: Bail in optimize_extract_to_float if we have modifiers

2019-02-14 Thread Lionel Landwerlin
On 12/02/2019 04:44, Jason Ekstrand wrote: This fixes a bug in runscape where we were optimizing x >> 16 to an extract and then negating and converting to float. The NIR to fs pass was dropping the negate on the floor breaking a geometry shader and causing it to render nothing. Fixes:

[Mesa-dev] [PATCH] intel/fs: Bail in optimize_extract_to_float if we have modifiers

2019-02-11 Thread Jason Ekstrand
This fixes a bug in runscape where we were optimizing x >> 16 to an extract and then negating and converting to float. The NIR to fs pass was dropping the negate on the floor breaking a geometry shader and causing it to render nothing. Fixes: 1f862e923cb "i965/fs: Optimize float conversions of