Re: [Mesa-dev] [PATCH] loader: disable virgl driver when no 3D for virtio

2018-04-05 Thread Emil Velikov
On 5 April 2018 at 14:45, Ilia Mirkin wrote: > Shouldn't this just be handled as in, e.g., > > https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/winsys/nouveau/drm/nouveau_drm_winsys.c#n97 > > i.e. return an error in the driver-specific loader? This create > function

Re: [Mesa-dev] [PATCH] loader: disable virgl driver when no 3D for virtio

2018-04-05 Thread Ilia Mirkin
Shouldn't this just be handled as in, e.g., https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/winsys/nouveau/drm/nouveau_drm_winsys.c#n97 i.e. return an error in the driver-specific loader? This create function should fail:

[Mesa-dev] [PATCH] loader: disable virgl driver when no 3D for virtio

2018-04-04 Thread Lepton Wu
If user are running mesa under old version of qemu or have turned off GL at runtime, virtio gpu driver actually doesn't work. Adding a detection here can make sure same disk image work with both cases. Signed-off-by: Lepton Wu --- src/loader/loader.c | 21