[Mesa-dev] [PATCH] mesa: do not define NDEBUG to make sure assert work

2011-10-08 Thread Yuanhan Liu
If you include mtypes.h, which would define macro NDEBUG, before including compiler.h, you would find that the assert macro will no longer work; it just make it slient by replacing it with ((void) (0)); Signed-off-by: Yuanhan Liu yuanhan@linux.intel.com --- src/mesa/main/mtypes.h |3 ---

Re: [Mesa-dev] [PATCH] mesa: do not define NDEBUG to make sure assert work

2011-10-08 Thread Kenneth Graunke
On 10/08/2011 02:08 AM, Yuanhan Liu wrote: If you include mtypes.h, which would define macro NDEBUG, before including compiler.h, you would find that the assert macro will no longer work; it just make it slient by replacing it with ((void) (0)); Signed-off-by: Yuanhan Liu

Re: [Mesa-dev] [PATCH] mesa: do not define NDEBUG to make sure assert work

2011-10-08 Thread Yuanhan Liu
On Sat, Oct 08, 2011 at 02:17:29AM -0700, Kenneth Graunke wrote: On 10/08/2011 02:08 AM, Yuanhan Liu wrote: If you include mtypes.h, which would define macro NDEBUG, before including compiler.h, you would find that the assert macro will no longer work; it just make it slient by replacing it