Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

2018-09-19 Thread Mark Janes
This patch broke all the intel systems also. Ilia Mirkin writes: > On Wed, Sep 19, 2018 at 7:04 AM, Jakob Bornecrantz > wrote: >> This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full >> setup is dEQP running on virgl with vtest that is running RadeonSI. So >> QEMU is not in the

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

2018-09-19 Thread Michel Dänzer
On 2018-09-19 1:10 p.m., Erik Faye-Lund wrote: > On on., sep. 19, 2018 at 1:04 PM, Jakob Bornecrantz > wrote: >> This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full >> setup is dEQP running on virgl with vtest that is running RadeonSI. So >> QEMU is not in the picture. All

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

2018-09-19 Thread Jakob Bornecrantz
On Wed, Sep 19, 2018 at 1:48 PM Ilia Mirkin wrote: > > On Wed, Sep 19, 2018 at 7:04 AM, Jakob Bornecrantz > wrote: > > This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full > > setup is dEQP running on virgl with vtest that is running RadeonSI. So > > QEMU is not in the picture.

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

2018-09-19 Thread Ilia Mirkin
On Wed, Sep 19, 2018 at 7:04 AM, Jakob Bornecrantz wrote: > This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full > setup is dEQP running on virgl with vtest that is running RadeonSI. So > QEMU is not in the picture. All instances of the Mesa driver is from > the same tree and have

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

2018-09-19 Thread Erik Faye-Lund
On on., sep. 19, 2018 at 1:04 PM, Jakob Bornecrantz wrote: This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full setup is dEQP running on virgl with vtest that is running RadeonSI. So QEMU is not in the picture. All instances of the Mesa driver is from the same tree and have

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

2018-09-19 Thread Jakob Bornecrantz
This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full setup is dEQP running on virgl with vtest that is running RadeonSI. So QEMU is not in the picture. All instances of the Mesa driver is from the same tree and have the patch applied. Cheers, Jakob. On Wed, Sep 12, 2018 at 12:05 PM

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

2018-09-17 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Sep 12, 2018 at 7:02 AM, Erik Faye-Lund wrote: > If we update the program-state etc, we risk compiling needless shaders, > which can cost quite a bit of performance. > > Signed-off-by: Erik Faye-Lund > --- > This was motivated by seeing an unexpected

[Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

2018-09-12 Thread Erik Faye-Lund
If we update the program-state etc, we risk compiling needless shaders, which can cost quite a bit of performance. Signed-off-by: Erik Faye-Lund --- This was motivated by seeing an unexpected shader-compile with nonsensical state on start-up in glxgears. src/mesa/main/clear.c | 34