Re: [Mesa-dev] [PATCH] meson: fix building without GL

2018-02-26 Thread Dylan Baker
Quoting Emil Velikov (2018-02-26 09:11:35) > On 26 February 2018 at 16:46, Dylan Baker wrote: > > libgl will be undefined if with_glx == 'disabled', so move that check > > inside the `if with_glx == 'disabled'` block immediately after that > > check. > > > There's some of

Re: [Mesa-dev] [PATCH] meson: fix building without GL

2018-02-26 Thread Dylan Baker
Quoting Eric Engestrom (2018-02-26 09:13:47) > On Monday, 2018-02-26 16:56:46 +, Eric Engestrom wrote: > > On Monday, 2018-02-26 08:46:54 -0800, Dylan Baker wrote: > > > libgl will be undefined if with_glx == 'disabled', so move that check > > > inside the `if with_glx == 'disabled'` block

Re: [Mesa-dev] [PATCH] meson: fix building without GL

2018-02-26 Thread Eric Engestrom
On Monday, 2018-02-26 16:56:46 +, Eric Engestrom wrote: > On Monday, 2018-02-26 08:46:54 -0800, Dylan Baker wrote: > > libgl will be undefined if with_glx == 'disabled', so move that check > > inside the `if with_glx == 'disabled'` block immediately after that > typo: s/==/!=/^^ >

Re: [Mesa-dev] [PATCH] meson: fix building without GL

2018-02-26 Thread Emil Velikov
On 26 February 2018 at 16:46, Dylan Baker wrote: > libgl will be undefined if with_glx == 'disabled', so move that check > inside the `if with_glx == 'disabled'` block immediately after that > check. > There's some of repetition, making this hard to read. Perhaps: "libgl

Re: [Mesa-dev] [PATCH] meson: fix building without GL

2018-02-26 Thread Eric Engestrom
On Monday, 2018-02-26 08:46:54 -0800, Dylan Baker wrote: > libgl will be undefined if with_glx == 'disabled', so move that check > inside the `if with_glx == 'disabled'` block immediately after that typo: s/==/!=/^^ Acked-by: Eric Engestrom > check. > >

Re: [Mesa-dev] [PATCH] meson: fix building without GL

2018-02-26 Thread Jason Ekstrand
Acked-by: Jason Ekstrand Untested-by: Jason Ekstrand On Mon, Feb 26, 2018 at 8:46 AM, Dylan Baker wrote: > libgl will be undefined if with_glx == 'disabled', so move that check > inside the `if with_glx == 'disabled'` block

[Mesa-dev] [PATCH] meson: fix building without GL

2018-02-26 Thread Dylan Baker
libgl will be undefined if with_glx == 'disabled', so move that check inside the `if with_glx == 'disabled'` block immediately after that check. Fixes: 5c460337fd9c109 ("meson: Fix GL and EGL pkg-config files with glvnd") Reported-by: Jason Ekstrand Signed-off-by: Dylan