Re: [Mesa-dev] [PATCH] meson: fix megadriver symlinking

[Dylan Baker]

Quoting Emil Velikov (2018-04-05 07:58:22)
> On 4 April 2018 at 18:45, Dylan Baker  wrote:
> > Which should be relative instead of absolute.
> >
> > Fixes: f7f1b30f81e842db6057591470ce3cb6d4fb2795
> >("meson: extend install_megadrivers script to handle symmlinking")
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105567
> > Signed-off-by: Dylan Baker 
> > ---
> >  bin/install_megadrivers.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/bin/install_megadrivers.py b/bin/install_megadrivers.py
> > index 86bfa359188..7931a544bd2 100755
> > --- a/bin/install_megadrivers.py
> > +++ b/bin/install_megadrivers.py
> > @@ -58,7 +58,7 @@ def main():
> >  while ext != '.so':
> >  if os.path.exists(name):
> >  os.unlink(name)
> > -os.symlink(driver, name)
> > +os.symlink(each, name)
> At a later stage, can we update the script to use more obvious names.

Yeah, I thought about that too, but this is fix that should land for 18.0.1, so
I wanted to minimize the churn.

Dylan

> 
> As-is patch does the job and is
> Reviewed-by: Emil Velikov 
> 
> -Emil


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] meson: fix megadriver symlinking

[Emil Velikov]

On 4 April 2018 at 18:45, Dylan Baker  wrote:
> Which should be relative instead of absolute.
>
> Fixes: f7f1b30f81e842db6057591470ce3cb6d4fb2795
>("meson: extend install_megadrivers script to handle symmlinking")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105567
> Signed-off-by: Dylan Baker 
> ---
>  bin/install_megadrivers.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bin/install_megadrivers.py b/bin/install_megadrivers.py
> index 86bfa359188..7931a544bd2 100755
> --- a/bin/install_megadrivers.py
> +++ b/bin/install_megadrivers.py
> @@ -58,7 +58,7 @@ def main():
>  while ext != '.so':
>  if os.path.exists(name):
>  os.unlink(name)
> -os.symlink(driver, name)
> +os.symlink(each, name)
At a later stage, can we update the script to use more obvious names.

As-is patch does the job and is
Reviewed-by: Emil Velikov 

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] meson: fix megadriver symlinking

[Eric Engestrom]

On Wednesday, 2018-04-04 10:45:26 -0700, Dylan Baker wrote:
> Which should be relative instead of absolute.
> 
> Fixes: f7f1b30f81e842db6057591470ce3cb6d4fb2795
>("meson: extend install_megadrivers script to handle symmlinking")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105567
> Signed-off-by: Dylan Baker 

Been using that locally for a couple months:
Reviewed-and-Tested-by: Eric Engestrom 

> ---
>  bin/install_megadrivers.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bin/install_megadrivers.py b/bin/install_megadrivers.py
> index 86bfa359188..7931a544bd2 100755
> --- a/bin/install_megadrivers.py
> +++ b/bin/install_megadrivers.py
> @@ -58,7 +58,7 @@ def main():
>  while ext != '.so':
>  if os.path.exists(name):
>  os.unlink(name)
> -os.symlink(driver, name)
> +os.symlink(each, name)
>  name, ext = os.path.splitext(name)
>  finally:
>  os.chdir(ret)
> -- 
> 2.16.3
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] meson: fix megadriver symlinking

[Dylan Baker]

Which should be relative instead of absolute.

Fixes: f7f1b30f81e842db6057591470ce3cb6d4fb2795
   ("meson: extend install_megadrivers script to handle symmlinking")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105567
Signed-off-by: Dylan Baker 
---
 bin/install_megadrivers.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/install_megadrivers.py b/bin/install_megadrivers.py
index 86bfa359188..7931a544bd2 100755
--- a/bin/install_megadrivers.py
+++ b/bin/install_megadrivers.py
@@ -58,7 +58,7 @@ def main():
 while ext != '.so':
 if os.path.exists(name):
 os.unlink(name)
-os.symlink(driver, name)
+os.symlink(each, name)
 name, ext = os.path.splitext(name)
 finally:
 os.chdir(ret)
-- 
2.16.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev