Re: [Mesa-dev] [PATCH] nir/builder: Don't emit no-op swizzles

2019-02-22 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Sat, Feb 23, 2019 at 1:14 AM Ian Romanick wrote: > > Reviewed-by: Ian Romanick > > On 2/22/19 4:03 PM, Jason Ekstrand wrote: > > The nir_swizzle helper is used some on it's own but it's also called by > > nir_channel and nir_channels which are used everywhere.

Re: [Mesa-dev] [PATCH] nir/builder: Don't emit no-op swizzles

2019-02-22 Thread Ian Romanick
Reviewed-by: Ian Romanick On 2/22/19 4:03 PM, Jason Ekstrand wrote: > The nir_swizzle helper is used some on it's own but it's also called by > nir_channel and nir_channels which are used everywhere. It's pretty > quick to check while we're walking the swizzle anyway whether or not > it's an

[Mesa-dev] [PATCH] nir/builder: Don't emit no-op swizzles

2019-02-22 Thread Jason Ekstrand
The nir_swizzle helper is used some on it's own but it's also called by nir_channel and nir_channels which are used everywhere. It's pretty quick to check while we're walking the swizzle anyway whether or not it's an identity swizzle. If it is, we now don't bother emitting the instruction.