Re: [Mesa-dev] [PATCH] nir: Document the function inlining process

2018-12-11 Thread Matt Turner
Thanks. This was very useful for me in the fp64 work. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] nir: Document the function inlining process

2018-12-11 Thread Karol Herbst
sorry, totally forgot about that. Seems fine as it is and I have the same within my CL branch (except the last nir_lower_constant_initializers). as I don't really know if all that is actually true, but because it makes sense to me: Acked-by: Karol Herbst I kind of wished we would have a helper

Re: [Mesa-dev] [PATCH] nir: Document the function inlining process

2018-12-11 Thread Jason Ekstrand
ping On Mon, Oct 29, 2018 at 12:14 PM Jason Ekstrand wrote: > This has thrown a few people off recently and it's good to have the > process and all the rational for it documented somewhere. A comment at > the top of nir_inline_functions seems as good a place as any. > > Cc: Matt Turner > Cc:

[Mesa-dev] [PATCH] nir: Document the function inlining process

2018-10-29 Thread Jason Ekstrand
This has thrown a few people off recently and it's good to have the process and all the rational for it documented somewhere. A comment at the top of nir_inline_functions seems as good a place as any. Cc: Matt Turner Cc: Karol Herbst --- src/compiler/nir/nir_inline_functions.c | 68