On Wed, Dec 19, 2018 at 1:12 PM Alan Swanson
wrote:
> On Mon, 2018-12-17 at 16:16 +, Rhys Perry wrote:
> > Signed-off-by: Rhys Perry
> > ---
> > src/compiler/nir/nir_opt_peephole_select.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/compiler/nir/nir_
On Mon, 2018-12-17 at 16:16 +, Rhys Perry wrote:
> Signed-off-by: Rhys Perry
> ---
> src/compiler/nir/nir_opt_peephole_select.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/compiler/nir/nir_opt_peephole_select.c
> b/src/compiler/nir/nir_opt_peephole_select.
On December 18, 2018 19:42:56 Rhys Perry wrote:
The 32-bit condition was in one of radv's meta shaders and had it from
the start.
32-bit conditions seems to be valid after lowering booleans to 32-bit.
Are they supposed to be invalid before the lowering?
It's not invalid in the sense that the
The 32-bit condition was in one of radv's meta shaders and had it from
the start.
32-bit conditions seems to be valid after lowering booleans to 32-bit.
Are they supposed to be invalid before the lowering?
On Wed, 19 Dec 2018 at 00:59, Jason Ekstrand wrote:
>
> Seems reasonable though I'm a bit
Seems reasonable though I'm a bit surprised your running peephole_select
after lowering booleans.
On December 18, 2018 18:16:46 Timothy Arceri wrote:
Reviewed-by: Timothy Arceri
On 18/12/18 3:16 am, Rhys Perry wrote:
Signed-off-by: Rhys Perry
---
src/compiler/nir/nir_opt_peephole_select
Reviewed-by: Timothy Arceri
On 18/12/18 3:16 am, Rhys Perry wrote:
Signed-off-by: Rhys Perry
---
src/compiler/nir/nir_opt_peephole_select.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/compiler/nir/nir_opt_peephole_select.c
b/src/compiler/nir/nir_opt_peephole_
Signed-off-by: Rhys Perry
---
src/compiler/nir/nir_opt_peephole_select.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/compiler/nir/nir_opt_peephole_select.c
b/src/compiler/nir/nir_opt_peephole_select.c
index ad9d0abec0..241627ed99 100644
--- a/src/compiler/nir/nir_o
