Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-06-05 Thread Emil Velikov
Hi all, Seems like I've got this stuck in the drafts queue. While the patch has been merged, I'm hitting "Send" for posterity. On 2 May 2018 at 21:38, Jan Vesely wrote: > @Emil, are you OK with this patch? > In a Tl;Dr; yes, patch is fine and is Reviewed-by: Emil Velikov A bit more detail on

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-15 Thread Kai Wasserbäch
Hey Jan, Jan Vesely wrote on 15.05.2018 04:50: > I've pushed the patch. thank you very much! I went ahead and closed the associated bug in the meantime. > I've also kept the stable tag although the > policy is (afaik) to only support llvm versions available at the point > of mesa release. Don't

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-14 Thread Jan Vesely
Hi Kai, I've pushed the patch. I've also kept the stable tag although the policy is (afaik) to only support llvm versions available at the point of mesa release. Don't be surprised to see some pushback from stable maintainers. thanks, Jan On Sun, 2018-05-13 at 23:19 +0200, Dieter Nützel wrote:

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-13 Thread Dieter Nützel
Hello Jan and Kai, would be nice if this lands (have T-b from me). Dieter Am 13.05.2018 19:10, schrieb Jan Vesely: Hi, sorry for the delay. I thought maybe Emil is on holiday. I plan to push this on Monday evening (EDT) if there is no response by then. Jan On Sun, May 13, 2018 at 3:56 AM,

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-13 Thread Jan Vesely
Hi, sorry for the delay. I thought maybe Emil is on holiday. I plan to push this on Monday evening (EDT) if there is no response by then. Jan On Sun, May 13, 2018 at 3:56 AM, Kai Wasserbäch wrote: > Ping! Can somebody *please* commit this patch? It fixes an FTBFS,

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-13 Thread Kai Wasserbäch
Ping! Can somebody *please* commit this patch? It fixes an FTBFS, has two T-b and one A-b. Kai Wasserbäch wrote on 07.05.2018 16:48: > Jan Vesely wrote on 02.05.2018 22:38: >> On Wed, 2018-05-02 at 18:38 +0200, Kai Wasserbäch wrote: >>> [...] >> >> Thank for looking into this. We probably need

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-07 Thread Kai Wasserbäch
Jan Vesely wrote on 02.05.2018 22:38: > On Wed, 2018-05-02 at 18:38 +0200, Kai Wasserbäch wrote: >> [...] > > Thank for looking into this. We probably need CLANG_LIBS handling > similar to LLVM_LIBS. I agree this is the best fix for now. > > Acked-by: Jan Vesely > >

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-02 Thread Jan Vesely
On Wed, 2018-05-02 at 18:38 +0200, Kai Wasserbäch wrote: > Hey Jan, > Jan Vesely wrote on 01.05.2018 23:59: > > On Tue, 2018-05-01 at 18:23 +0200, Kai Wasserbäch wrote: > > > Jan Vesely wrote on 01.05.2018 17:19: > > > > On Tue, 2018-05-01 at 14:14 +0200, Kai Wasserbäch wrote: > > > > > [...] > >

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-02 Thread Kai Wasserbäch
Hey Jan, Jan Vesely wrote on 01.05.2018 23:59: > On Tue, 2018-05-01 at 18:23 +0200, Kai Wasserbäch wrote: >> Jan Vesely wrote on 01.05.2018 17:19: >>> On Tue, 2018-05-01 at 14:14 +0200, Kai Wasserbäch wrote: [...] src/gallium/targets/opencl/Makefile.am | 3 +-- 1 file changed,

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-01 Thread Dieter Nützel
Tested-by: Dieter Nützel Dieter Am 01.05.2018 14:14, schrieb Kai Wasserbäch: Otherwise the build fails with an undefined reference to clang::FrontendTimesIsEnabled. Bugzilla: https://bugs.freedesktop.org/106209 Cc: mesa-sta...@lists.freedesktop.org Cc: Jan Vesely

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-01 Thread Jan Vesely
On Tue, 2018-05-01 at 18:23 +0200, Kai Wasserbäch wrote: > Hey Jan, > Jan Vesely wrote on 01.05.2018 17:19: > > On Tue, 2018-05-01 at 14:14 +0200, Kai Wasserbäch wrote: > > > Otherwise the build fails with an undefined reference to > > > clang::FrontendTimesIsEnabled. > > > > > > Bugzilla:

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-01 Thread Kai Wasserbäch
Hey Jan, Jan Vesely wrote on 01.05.2018 17:19: > On Tue, 2018-05-01 at 14:14 +0200, Kai Wasserbäch wrote: >> Otherwise the build fails with an undefined reference to >> clang::FrontendTimesIsEnabled. >> >> Bugzilla: https://bugs.freedesktop.org/106209 >> Cc: mesa-sta...@lists.freedesktop.org >>

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-01 Thread Jan Vesely
On Tue, 2018-05-01 at 14:14 +0200, Kai Wasserbäch wrote: > Otherwise the build fails with an undefined reference to > clang::FrontendTimesIsEnabled. > > Bugzilla: https://bugs.freedesktop.org/106209 > Cc: mesa-sta...@lists.freedesktop.org > Cc: Jan Vesely > Signed-off-by:

[Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-01 Thread Kai Wasserbäch
Otherwise the build fails with an undefined reference to clang::FrontendTimesIsEnabled. Bugzilla: https://bugs.freedesktop.org/106209 Cc: mesa-sta...@lists.freedesktop.org Cc: Jan Vesely Signed-off-by: Kai Wasserbäch --- Hey, this patch