Re: [Mesa-dev] [PATCH] panfrost: Fix ->set_vertex_buffers() for partial vertex bufs updates

2019-04-15 Thread Alyssa Rosenzweig
The patches I just posted to the list conflict with this but I think do what you want. Could you try those? Thanks, -AR ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] panfrost: Fix ->set_vertex_buffers() for partial vertex bufs updates

2019-04-12 Thread Alyssa Rosenzweig
Reviewed-by: Alyssa Rosenzweig Looks great! pan_context.c is definitely some of the most fragile code in the driver right now, so I'm thrilled to get some attention to clean it up :) (Not tested by me yet -- I won't be able to test until next week)

[Mesa-dev] [PATCH] panfrost: Fix ->set_vertex_buffers() for partial vertex bufs updates

2019-04-12 Thread Boris Brezillon
The caller of ->set_vertex_buffers() might want to update only a subset of the currently active vertex buffers, hence the start_slot and num_buffers arguments. The panfrost driver was assuming that the whole set of vertex buffers were to be freed/updated each time this hook is called, which leads